unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Thomas Danckaert <thomas.danckaert@gmail.com>
Cc: guix-devel@gnu.org
Subject: Graft slowness fixed
Date: Mon, 16 Jan 2017 22:18:55 +0100	[thread overview]
Message-ID: <87tw8y66v4.fsf@gnu.org> (raw)
In-Reply-To: <1484159585-12289-1-git-send-email-thomas.danckaert@gmail.com> (Thomas Danckaert's message of "Wed, 11 Jan 2017 19:33:01 +0100")

Hi Thomas,

Thomas Danckaert <thomas.danckaert@gmail.com> skribis:

> There is one issue: when I apply this patch series on current master (after
> commit e10872c gnu: gpgme: Patch CMake files), `guix build kdevelop` seems to
> get stuck after completing the build (at least it doesn't return after running
> at ~100%cpu for over 40minutes, with no output).  When I apply the patch
> series on commit 4d0a3d8 (system: grub: Load relevant EFI modules on EFI
> systems), I don't have this problem.  I'm not sure if this is an issue just on
> my system, or not (I upgraded guix-daemon to lastest master, but the problem
> remains). Hints on how to investigate this are welcome!

You found a terrrrrible issue that somehow went unnoticed for two weeks!

This cute commit:

  http://git.savannah.gnu.org/cgit/guix.git/commit/?id=d38bc9a9f6feefc465964531520fee5663a12f48

had the effect of disabling caching in the DAG traversal performed by
‘graft-derivation’.  For big DAGs like that of kdevelop, you could
really feel it.  :-)

This is fixed by this one-liner:

  http://git.savannah.gnu.org/cgit/guix.git/commit/?id=90ad5c8836138b7fd4d1bd0243dfa8b30ae0cf21

This other one fixes a related issue that had always been there apparently:

  http://git.savannah.gnu.org/cgit/guix.git/commit/?id=0aeed5e310504a9ef2cf6a2b2a7e76086eb8c2fc

Thanks for the heads-up!

Ludo’.

      parent reply	other threads:[~2017-01-16 21:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 18:33 [PATCH 0/4] kdevelop updates Thomas Danckaert
2017-01-11 18:33 ` [PATCH 1/4] gnu: kdevelop: Update to 5.0.3 Thomas Danckaert
2017-01-16 20:07   ` Ludovic Courtès
2017-01-11 18:33 ` [PATCH 2/4] gnu: kdevelop: Set more paths in wrapper script Thomas Danckaert
2017-01-16 20:09   ` Ludovic Courtès
2017-01-11 18:33 ` [PATCH 3/4] gnu: Add kdev-python Thomas Danckaert
2017-01-16 21:10   ` Ludovic Courtès
2017-01-16 22:39     ` Danny Milosavljevic
2017-01-19 17:14       ` Thomas Danckaert
2017-01-20 13:36         ` Ludovic Courtès
2017-01-11 18:33 ` [PATCH 4/4] gnu: Add python-autopep8 Thomas Danckaert
2017-01-16 21:14   ` Ludovic Courtès
2017-01-16 21:18 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw8y66v4.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=thomas.danckaert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).