Hi Roel,

Roel Janssen <roel@gnu.org> skribis:

> I'd like to change the way the symlinks to custom profiles are created.
> Here's what currently happens:
>
> $ guixr package -i hello -p guix-profiles/test
> $ ls -l guix-profiles
> lrwxrwxrwx. 1 user group 25 Jul  3 19:53 test -> guix-profiles/test-1-link
> lrwxrwxrwx. 1 user group 51 Jul  3 19:53 test-1-link -> /gnu/store/...6qbaps-profile
>
> Now, that symlink is broken.
> Instead, I'd like to have it always use absolute paths:

How about instead making the link to the generation file (“test-1-link”)
always a relative symlink?  Like this:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix package -p foo/x -i sed

[...]

$ ls -l foo/*
lrwxrwxrwx 1 ludo users  8 Jul 11 13:03 foo/x -> x-1-link
lrwxrwxrwx 1 ludo users 51 Jul 11 13:03 foo/x-1-link -> /gnu/store/qp6dqlbsf0pw9p9fwc3gzdcaxx40rn9v-profile
--8<---------------cut here---------------end--------------->8---

Patch below.

FWIW I prefer avoiding ‘canonicalize-path’ in general because it’s
inefficient and because it can surprise the user: you can end up with a
long file name that you didn’t type in, or you can have ENOENT errors
because ‘canonicalize-path’ requires the given file to exist.

WDYT?

Thanks,
Ludo’.