From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: Octave & QtOctave Date: Fri, 07 Dec 2018 10:52:06 -0500 Message-ID: <87tvjpwd09.fsf@posteo.net> References: <875zwnqomz.fsf@posteo.net> <87a7lyzkk2.fsf@gmail.com> <20181124221022.ankjuz4mdpkoohkn@abyayala> <87k1l1w3n0.fsf@gnu.org> <87in0ijtku.fsf@posteo.net> <87va4h5vhr.fsf@gnu.org> <87a7lnk9sb.fsf@posteo.net> <871s6xz894.fsf@gmail.com> <87woopovyk.fsf@posteo.net> <878t13mdcj.fsf@gmail.com> <87in06mzjz.fsf@posteo.net> <87zhtilf2k.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVIQn-0007WM-7j for guix-devel@gnu.org; Fri, 07 Dec 2018 10:52:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVIQh-0007y6-1v for guix-devel@gnu.org; Fri, 07 Dec 2018 10:52:45 -0500 Received: from mout02.posteo.de ([185.67.36.66]:50371) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gVIQd-0006tp-4N for guix-devel@gnu.org; Fri, 07 Dec 2018 10:52:36 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id BEB9C2400FD for ; Fri, 7 Dec 2018 16:52:26 +0100 (CET) In-Reply-To: <87zhtilf2k.fsf@gmail.com> (Alex Vong's message of "Fri, 07 Dec 2018 01:50:43 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Vong Cc: guix-devel --=-=-= Content-Type: text/plain Alex Vong writes: > Kei Kebreau writes: > >> Alex Vong writes: >> >>> Kei Kebreau writes: >>> >>>> Alex Vong writes: >>>> >>>>> Hello Kei, >>>>> >>>>> Kei Kebreau writes: >>>>> >>>>> [...] >>>>>> >>>>>> Here are two tentative patches that make the changes we've discussed. >>>>>> Also, should we make a deprecated-package definition for qtoctave? >>>>> >>>>> I think some additional changes related to "(assoc-ref inputs ..." >>>>> needed to be made. Otherwise, looks good to me! Here is a patch I made >>>>> earlier but it was not tested, feel free to cherry-pick what is needed: >>>>> >>>>> From 2b04caa66c17da257dfb4f4ccb94e8d629b95e53 Mon Sep 17 00:00:00 2001 >>>>> From: Alex Vong >>>>> Date: Mon, 3 Dec 2018 03:39:40 +0800 >>>>> Subject: [PATCH] gnu: Rename "octave" to "octave-cli" and "qtoctave" to >>>>> "octave". >>>>> >>>>> * gnu/packages/maths.scm (octave): Rename to octave-cli. >>>>> [name]: Change to "octave-cli". >>>>> (qtoctave): Rename to octave. >>>>> [name]: Change to "octave". >>>>> [inherit]: Inherit from octave-cli. >>>>> [source]: Likewise. >>>>> [inputs]: Likewise. >>>>> [native-inputs]: Likewise. >>>>> [arguments]: Likewise. >>>>> (flann): Update accordingly. >>>>> * gnu/packages/engineering.scm (qucs): Likewise. >>>>> (qucs-s): Likewise. >>>>> * gnu/packages/machine-learning.scm (shogun): Likewise. >>>> >>>> ... >>>> >>>>> - ("octave" ,octave) >>>>> + ("octave-cli" ,octave-cli) >>>> >>>> I see the main difference is that you've replace the package's >>>> associated string to "octave-cli" as well as the name, whereas I've only >>>> replaced the package name. Should I replace the associated package >>>> string, too? >>> >>> According to the manual "6.7.2 Package Naming", the associated string is >>> used for package management commands such as 'guix package' and 'guix >>> build'. Therefore, I think we should change them as well, so that the >>> users can install the packages using the command >>> "guix package -i octave-cli" and "guix package -i octave" >>> respectively. What do you think? >> >> Maybe this is true when manipulating the package definition, but that >> doesn't seem to be the case in general. When I run >> "./pre-inst-env guix package --show=shogun", for example, >> "octave-cli@4.4.1" is listed as a dependency, even though "octave" is >> the associated name in shogun's input list. >> >> To be clear, I've changed the string for octave's and octave-cli's >> package name in their respective package definitions, but I haven't >> changed the string in the input lists of octave-cli's dependent >> packages. >> >> I'm inclined to follow convention when it comes to this, and other >> packages in input lists seem to omit extensions to the base name of the >> package in their assoc-lists. For example, ("gettext", gettext-minimal) >> and ("python", python-minimal-wrapper) are common inputs for packages. > > I think you are right! This was a misunderstanding on my part. I thought > the association string in the input lists must be the same as the > package name, but appraently this is not the case. > > Take gettext-minimal as an example, > its variable name is 'gettext-minimal', > its package name is "gettext-minimal", > but its input name is "gettext". Precisely! Unless anyone else has concerns that should be brought to light, I'll be committing this within the next 2 days. Thank you to all involved so far. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlwKlyYACgkQ5qXuPBlG eg3Gbg//cbeRss3BPmiUooffWvn1R9W9PJXWnN2FmrFPF0k7WlA6fOnnUjerJT/M ZE5WSHSSz3fPrPxatlCPIA2ApxkuqksgO+nDXoSmXeMQcm3grBsGAD5y4Owy3R4f PpIAy4xblzRcquGfRRRWhM+Jbfas/P5GynFh1eqcMglUMg6eDr3QeJouwar+ECX3 ChBAP/VIVbGF5zdhPFZSZik6hIa9mxMUP1qq679QUm6Mxj589HwyXJWgjlc87TXM I1NtIVqh2+1b+APo6lfEHL2PUxNodwWyGLEptZzz0zvDITM/oLa9gPG5gcjegGIp xlS7dgnfXTcGOMdBaHBuQVTD1M0WeUoBfyY1vrKa3zx9aeqZN4lv7C0+YyLOffG4 leLEo6JYfVk3KSo5awCu4LN7kcV9KIXH0XPE/LLFz3Wb4Bp6OeomxMd6fqIHNUsq 24C01LyFoZSDJicAvZtFZgSYcWBbqtgpQhzGqglZfrsuV8oCq2CAMps8gK5/8Qwp 0Sehc7NN6aYvH9EPUeQG7KLy77GN9h71zg132k6GsubykQJ3QfjLPlFRjgvxih1P hdtC6HNXlUBdXk1RIVx+OkROTABvKkl0DEdnKjTLh0suEqHKekiF3K7rFIDnZY+I jBfcFqye+W1ncfc0YIc0KO241H2kjfrmddcdujEeT5bX105JSBM= =ikRn -----END PGP SIGNATURE----- --=-=-=--