unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: Guix-devel <guix-devel@gnu.org>
Subject: .guix-channel: Quote inconsistency
Date: Mon, 08 Apr 2019 19:26:40 +0200	[thread overview]
Message-ID: <87tvf89zn3.fsf@ambrevar.xyz> (raw)

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

Today I got tripped by some inconsistency in the syntax.  Observe:

- ~/.config/guix/channels.scm

     (list (channel
             (name 'guix)
             (url "https://example.org/my-guix.git")
             (branch "super-hacks")))

- /some/channel/with/deps/.guix-channel:

     (channel
      (version 0)
      (dependencies
       (channel
        (name some-collection)
        (url "https://example.org/first-collection.git"))
       (channel
        (name some-other-collection)
        (url "https://example.org/second-collection.git")
        (branch "testing"))))

(Those are examples taken from the manual.)

The former NAME field takes a quote while the latter does not.
In the latter, when adding a quote we get the not-so-helpful error:

--8<---------------cut here---------------start------------->8---
guix/channels.scm:326:22: Throw to key `match-error' with args `("match" "no matching pattern" #f)'.
--8<---------------cut here---------------end--------------->8---

(Admittedly the backtrace gives a clue on what's happening, but still.)

I haven't looked at the code and I guess that .guix-channel is only
READ, not EVALed, while channels.scm is a first-class scheme code,
right?

Maybe we could match both 'SOME-NAME and SOME-NAME?

Thoughts?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

             reply	other threads:[~2019-04-08 17:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 17:26 Pierre Neidhardt [this message]
2019-04-10 21:06 ` .guix-channel: Quote inconsistency Ludovic Courtès
2019-04-11  8:31   ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvf89zn3.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).