From: "Ludovic Courtès" <ludo@gnu.org>
To: Robert Vollmert <rob@vllmrt.net>
Cc: guix-devel@gnu.org
Subject: Re: git-fetch origin output is read-only - and reproducibility
Date: Thu, 22 Aug 2019 23:41:59 +0200 [thread overview]
Message-ID: <87tva8j2s8.fsf@gnu.org> (raw)
In-Reply-To: <C723E1A3-A406-4A43-84EC-9F9C0BF46A6F@vllmrt.net> (Robert Vollmert's message of "Tue, 30 Jul 2019 09:37:14 +0200")
Hi,
Robert Vollmert <rob@vllmrt.net> skribis:
> On 29. Jul 2019, at 18:10, Ricardo Wurmus <rekado@elephly.net> wrote:
>> Most build systems inherit from the gnu-build-system, so they’ll get to
>> reuse the “unpack” phase, which conveniently checks if the source is a
>> tarball. In the case of Java archives it doesn’t do the right thing,
>> because it doesn’t know about Jars, so the ant-build-system overrides
>> that phase, etc.
>>
>> Dealing with sources sometimes requires special knowledge and the build
>> system might be best equipped to employ that knowledge.
>>
>> What would you suggest the fetchers implement to guarantee that the
>> sources will always be of some expected form?
>
> I would suggest that they specify the archive type, and either
>
> - repack the archive to a standard format, e.g. .tar.gz (this should then also
> apply to sources that are local directory trees)
> - unpack the archive to a directory tree
Note that ‘git-fetch’ & co. currently produced fixed-output derivations.
If ‘git-fetch’ were to systematically repack to a tarball, we’d
introduce a dependency on tar + some compressor, which is not always
desirable.
> An alternative change that would make the whole setup a bit less confusing
> would be to factor all the “standard” build system stuff out of gnu-build-system
> and into a base-build-system that provides source unpacking and phase handling
> and nothing else.
I agree that this would be an improvement.
Ludo’.
prev parent reply other threads:[~2019-08-22 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 14:57 git-fetch origin output is read-only - and reproducibility Danny Milosavljevic
2019-07-29 15:49 ` Ricardo Wurmus
2019-07-29 15:58 ` Robert Vollmert
2019-07-29 16:10 ` Ricardo Wurmus
2019-07-30 7:37 ` Robert Vollmert
2019-08-22 21:41 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tva8j2s8.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rob@vllmrt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).