Messed up with (guix ssh)

Messed up with (guix ssh)

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

Hi Guix,

I recently added a progress bar for ‘guix copy’:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=b03267df6d5ec44e9617b6aab0df14a2e79f822e

However that commit also includes a debugging leftover that breaks
‘send-files’ (in some but not all cases).  Can you spot it?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 171 bytes --]

-         (missing (inferior-remote-eval
+         (missing (take files 20) #;(inferior-remote-eval
                    `(begin
                       (use-modules (guix)

[-- Attachment #3: Type: text/plain, Size: 443 bytes --]


I noticed it as I experienced the first problems (offloading would
sometimes fail while sending files) and fixed it:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=de83660dd386b73957fe4ad2dc08ce5b8e1f0e7f

I also add to re-update the ‘guix’ package.

So I wanted to give a heads-up and apologize.  It got me thinking; this
patch hadn’t gone through guix-patches, which could have prevented this,
maybe.

Ludo’.

Re: Messed up with (guix ssh)

[Jan Nieuwenhuizen]

Ludovic Courtès writes:

Hello!

> So I wanted to give a heads-up and apologize.  It got me thinking; this
> patch hadn’t gone through guix-patches, which could have prevented this,
> maybe.

Thanks for the heads-up and quick fix.  I'm often amazed how well
guix-patches work, notably also for catching/preventing silly mistakes.

I think it's a trade-off and not all black and white, to get a feel
for where the boundary is we have to cross it now and then.  Dunno,
very happy with what you're doing :-)

Janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Re: Messed up with (guix ssh)

[Ludovic Courtès]

Hi!

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

>> So I wanted to give a heads-up and apologize.  It got me thinking; this
>> patch hadn’t gone through guix-patches, which could have prevented this,
>> maybe.
>
> Thanks for the heads-up and quick fix.  I'm often amazed how well
> guix-patches work, notably also for catching/preventing silly mistakes.
>
> I think it's a trade-off and not all black and white, to get a feel
> for where the boundary is we have to cross it now and then.  Dunno,
> very happy with what you're doing :-)

Heh, thanks for the kind words.

It reminded me of things like “goto fail;” though, so I thought like
giving a heads-up was the least I could do.  A similar mistake in
git-authenticate.scm or substitute.scm would have a very different
effect…

Ludo’.