* [ungrafting] cURL is missing the 'curl-use-ssl-cert-env' patch
@ 2020-12-13 0:37 Marius Bakke
2020-12-13 23:16 ` Marius Bakke
0 siblings, 1 reply; 3+ messages in thread
From: Marius Bakke @ 2020-12-13 0:37 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
Hello,
As you may have noticed, there is a new "ungrafting" branch that intends
to remove most of the "grafts" people have to deal with on a regular
basis.
The CI (and undersigned) have gotten pretty far on building this branch,
but there is a problem: cURL lost its "curl-use-ssl-cert-env" patch in
commit cb8569e10c766f180c48c7cf74b74f7b4cb74541.
This patch adds support for the SSL_CERT_DIR and SSL_CERT_FILE variables
for any application using libcurl.
I only noticed this because I merged a new graft for cURL (1adeb74456,
a7737f0ead).
Now the question is: should we restore this patch, and in practice
restart the branch almost from scratch? Or drop it, considering
upstream has rejected it[0]?
[0] https://github.com/curl/curl/pull/4809
As a middle ground, we can add it to the recent graft added in
1adeb74456, which won't require rebuilds.
Thoughts?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ungrafting] cURL is missing the 'curl-use-ssl-cert-env' patch
2020-12-13 0:37 [ungrafting] cURL is missing the 'curl-use-ssl-cert-env' patch Marius Bakke
@ 2020-12-13 23:16 ` Marius Bakke
2020-12-14 10:45 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Marius Bakke @ 2020-12-13 23:16 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
Marius Bakke <marius@gnu.org> skriver:
> Now the question is: should we restore this patch, and in practice
> restart the branch almost from scratch? Or drop it, considering
> upstream has rejected it[0]?
Following a discussion on IRC, we decided to reinstate the patch and get
rid of the newly added graft at the same time.
Apologies to those who already started building it!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ungrafting] cURL is missing the 'curl-use-ssl-cert-env' patch
2020-12-13 23:16 ` Marius Bakke
@ 2020-12-14 10:45 ` Ludovic Courtès
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2020-12-14 10:45 UTC (permalink / raw)
To: Marius Bakke; +Cc: guix-devel
Hi!
Marius Bakke <marius@gnu.org> skribis:
> Marius Bakke <marius@gnu.org> skriver:
>
>> Now the question is: should we restore this patch, and in practice
>> restart the branch almost from scratch? Or drop it, considering
>> upstream has rejected it[0]?
>
> Following a discussion on IRC, we decided to reinstate the patch and get
> rid of the newly added graft at the same time.
>
> Apologies to those who already started building it!
Thanks for the heads-up, and apologies for making this mistake in the
first place!
As we speak, substitute availability is at 34% on x86_64-linux…
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-14 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-13 0:37 [ungrafting] cURL is missing the 'curl-use-ssl-cert-env' patch Marius Bakke
2020-12-13 23:16 ` Marius Bakke
2020-12-14 10:45 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).