From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ePrRKR6L+V/BTwAA0tVLHw (envelope-from ) for ; Sat, 09 Jan 2021 10:53:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UJmgJR6L+V8jHwAA1q6Kng (envelope-from ) for ; Sat, 09 Jan 2021 10:53:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CFAA6940481 for ; Sat, 9 Jan 2021 10:53:17 +0000 (UTC) Received: from localhost ([::1]:56494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyBrw-0000Ud-Nk for larch@yhetil.org; Sat, 09 Jan 2021 05:53:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyBrm-0000T5-OO for guix-devel@gnu.org; Sat, 09 Jan 2021 05:53:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58131) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyBrl-0004ZE-A4; Sat, 09 Jan 2021 05:53:05 -0500 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=36314 helo=dundal.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kyBrk-0000xO-IU; Sat, 09 Jan 2021 05:53:04 -0500 From: Jan Nieuwenhuizen Subject: Re: 04/06: services: hurd-vm: Avoid circular dependency with (gnu system images hurd). Organization: AvatarAcademy.nl References: <20201207114951.24738.95603@vcs0.savannah.gnu.org> <20201207114953.D97D220CEB@vcs0.savannah.gnu.org> to: "Ludovic =?utf-8?Q?Court=C3=A8s?= " X-Url: http://AvatarAcademy.nl Date: Sat, 09 Jan 2021 11:53:01 +0100 In-Reply-To: <20201207114953.D97D220CEB@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Mon, 7 Dec 2020 06:49:53 -0500 (EST)") Message-ID: <87turqwfea.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: CFAA6940481 X-Spam-Score: -2.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: faGm2yeQzonn Hi! On current master, the disk-size setting on a childhurd has no effect, leaving very little disk space to do development. I am suspecting this commit > commit 859b362f81598830d7ff276b96a8724aee3c4db7 > Author: Ludovic Court=C3=A8s > AuthorDate: Mon Dec 7 12:38:25 2020 +0100 > > services: hurd-vm: Avoid circular dependency with (gnu system images = hurd). >=20=20=20=20=20 > * gnu/services/virtualization.scm (hurd-vm-disk-image): Use > 'lookup-image-type-by-name' instead of referring to 'hurd-disk-image' > from (gnu system images hurd). > --- > gnu/services/virtualization.scm | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualizatio= n.scm > index eaf0bbd..f435630 100644 > --- a/gnu/services/virtualization.scm > +++ b/gnu/services/virtualization.scm [..] > @@ -913,14 +912,12 @@ that will be listening to receive secret keys on po= rt 1004, TCP." > (define (hurd-vm-disk-image config) > "Return a disk-image for the Hurd according to CONFIG. The secret-ser= vice > is added to the OS specified in CONFIG." > - (let ((os (secret-service-operating-system (hurd-vm-configuration-os c= onfig))) > - (disk-size (hurd-vm-configuration-disk-size config))) > - (system-image > - (image > - (inherit hurd-disk-image) > - (format 'compressed-qcow2) > - (size disk-size) > - (operating-system os))))) This system-image included (size disk-size), and here > + (let* ((os (secret-service-operating-system > + (hurd-vm-configuration-os config))) > + (disk-size (hurd-vm-configuration-disk-size config)) > + (type (lookup-image-type-by-name 'hurd-qcow2)) > + (os->image (image-type-constructor type))) > + (system-image (os->image os)))) disk-size goes unused. Greetings, Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com