From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CPIIFsG1eGAqPwEAgWs5BA (envelope-from ) for ; Thu, 15 Apr 2021 23:53:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eIrZD8G1eGADCwAAbx9fmQ (envelope-from ) for ; Thu, 15 Apr 2021 21:53:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FCA9CB73 for ; Thu, 15 Apr 2021 23:53:04 +0200 (CEST) Received: from localhost ([::1]:32988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX9v5-0001WU-D5 for larch@yhetil.org; Thu, 15 Apr 2021 17:53:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX9us-0001Tq-3s for guix-devel@gnu.org; Thu, 15 Apr 2021 17:52:50 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:42509) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX9uq-0002Dm-4L for guix-devel@gnu.org; Thu, 15 Apr 2021 17:52:49 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id E290327BC76; Thu, 15 Apr 2021 22:52:45 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 65df9ad3; Thu, 15 Apr 2021 21:52:45 +0000 (UTC) References: <79d3d2e5c1386b1e162f1ba8380562720131856d.camel@telenet.be> User-agent: mu4e 1.4.15; emacs 27.1 From: Christopher Baines To: Canan Talayhan Subject: Re: [Outreachy] - Guix Data Service - Set a more informative page title In-reply-to: Date: Thu, 15 Apr 2021 22:52:42 +0100 Message-ID: <87tuo7xljp.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618523585; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=9hm0QFaEW/yilfujnL8kCbtQbra9UCB7SqJ2uGKOGgw=; b=T0q0Mu5SYqnIyGHmrTIPWMUR0w2hQuEyo8wFJLzr7Onj5TniimLxASff/Negrqs24LVK64 TLry9zg9y1D9bPVbB7UBOSjl5dbsXmV0AkY86c7YwaGSm2vEt0vt33e3LUUthmEyg3d60I PKJxNR25HFuOOPH6xeg0GMCH2oYj3qRL4eXAuEOYDJrDLfXGn/KwGb6O6YaQYtSc4ONkg0 el71FEdbxm20G5Q9dI98/7GYSOiF/HXCHtq1Bi/6ZVMkKEceCsb+7X6HJ8IjNCgvvcG68x M5w7hdTCsxUlo59K2+VDNBltpCAyp3/sJMTr0IWMX3nYYOX8Cu+ckLOeaFGXKQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618523585; a=rsa-sha256; cv=none; b=Xy9WVBDorqrroS1Q/CGIL6wYoPUL5NdRyAEyq2FeG3v8XZNz4N0ui181ZUGxy6qgeygXof e3QPJ0cJe+u/meYniMJPQIKTKk5AFI1lZ1kC2lgJ42grVHCwvrHAaKBh1U4vFv5Fo4Fcs7 KqqFs5ZPUwPUaFriugf6F4IlCLlJB0NjlOv+deCwXISN0VEp0/o0jhOQUCDg5MCXYA5tl0 oUx/hTIK3wYPC9e1OIYWI7kLoY1ABBwhYepbojsJocKX9s/y3ebYTgC1aQGsEdKIfujXYT 3FEKCQJUsFL49x6PrclLLd5nlmuxfUVSr1qWBSMrwTLZZAeio8LbDgN5qfllEA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -4.54 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 6FCA9CB73 X-Spam-Score: -4.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: mQiMYGjE802Z --=-=-= Content-Type: text/plain Canan Talayhan writes: > Hi team, > > Thanks for your help. > > @Chris > After all the modifications that I've made according to your comments, > I've created the latest version of my patch. > Could you please review the patch attached and share your ideas? > > Please note that a few parts are left. After your confirmation, I can > handle it shortly. Thanks Canan, I've had a quick look: > +(define page-header "Dumps") > + > (define (view-dumps available-dumps) > (layout > + #:title > + page-header > #:body > `(,(header) > (div > @@ -31,7 +35,7 @@ > (@ (class "row")) > (div > (@ (class "col-sm-12")) > - (h1 "Database dumps"))) > + (h1 ,page-header))) I'd generally stick with more descriptive titles, "Database dumps" is far clearer than "Dumps" in this case. > + (define page-header "Recent Events") > + > (layout > + #:title > + page-header > #:body > `(,(header) > (div > @@ -200,7 +208,7 @@ > (@ (class "col-sm-12")) > (a (@ (href "/jobs")) > (h3 "Jobs")) > - (h1 "Recent events"))) > + (h1 ,page-header))) The capitalisation used here "events" rather than "Events" is intentional, I wouldn't change it while looking at the titles at least. > (define (view-job job-id query-parameters log) > + (define page-header "Job") > + > (layout > + #:title > + (string-append page-header " " job-id) > #:body > `(,(header) > (div > @@ -339,7 +356,7 @@ > (@ (class "row")) > (div > (@ (class "col-sm-12")) > - (h1 "Job " ,job-id))) > + (h1 ,page-header ," " ,job-id))) I'd be tempted to combine the Job string and the job-id then use it for both the #:title and h1 element. > + (string-append page-header " " (string-take commit-hash 7) " Channel News Entries") This title looks good, I'd put the more specific bits nearer the start though, so I'd put "Channel News Entries" first, then the Revision bit second. Also, watch out for the line length, I'd indent this so it's not longer than 80 lines. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmB4tapfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XckFA//aNOPlWMG7qrlXeQ+dT7a2jKHrhmO6xGv m1BX4e3wjvuNkuzWES8m/qQQmTtgTu6K2R+aiX18jVjoFmzig8PHCoEQ8fVdU6gc 8SRGzYmhVb6OVRVeLTx2Txb5xUjRmJFtYqNnE2ffgF5Lms5PHO7Wuqc7eMWTtp+M BzHmzcPp6nf/KsKfw774Pf541Dz8/H/yy76onYZsBkNG+dUE/e4DOITw65tiHtzF LN1xBt6AbVeKaVlL5dnhQmHgTIbsxqzLCoEgOlnENKNMuDg7X0auCs5oOeDmboBs oPOgT5993isCAfi20v7cEUtBR49qO6qMyfM3IjJIqwYfvz9RZ2IsUrRFyewms6lG mDdARxM6UpIcrXcRd5a3tNv0mcxe53DiyplOfv7/YfwEciIgxRqErUTUnPLadCyE 5wPKAiXU0FallSbUxsyZnFqO4dLMH+Xh4cfhNs0XhgpVYnFnNzCuMD9Z6BphHtOJ lDvvL9o+9BESNDzvoHjXdwawGcLnRl5BQ3fX7ol6nyYcHwMMlPyhh0bKOmETuQCU SGNTiufrOijKbc3czF/s73HMCOMIUcG2TeArTYJgVP5tm52JygM3umy0rGn+tOJZ AAaggHIUWTz5K9TK9eVe44u/uDIKe7mJtcDTQOJzUpgFK8jzcnCuk0LKIykg63mf btO++A8N+L8= =7HH1 -----END PGP SIGNATURE----- --=-=-=--