From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6MxEODmGmGFp4wAAgWs5BA (envelope-from ) for ; Sat, 20 Nov 2021 06:23:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qM0zMzmGmGGSWwAA1q6Kng (envelope-from ) for ; Sat, 20 Nov 2021 05:23:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8EF132D649 for ; Sat, 20 Nov 2021 06:23:05 +0100 (CET) Received: from localhost ([::1]:56064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moIq8-0002Eg-FY for larch@yhetil.org; Sat, 20 Nov 2021 00:23:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moIou-0002C6-1S for guix-devel@gnu.org; Sat, 20 Nov 2021 00:21:48 -0500 Received: from [2600:3c01:e000:267:0:a171:de7:c] (port=37610 helo=cascadia.aikidev.net) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moIos-0000hg-3D; Sat, 20 Nov 2021 00:21:47 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 06C051AA41; Fri, 19 Nov 2021 21:21:43 -0800 (PST) From: Vagrant Cascadian To: Philip McGrath , Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= Subject: Re: default tar format for "make dist" and patch file length In-Reply-To: <071f69a4-4e8a-3337-6a84-6ceca5119e6f@philipmcgrath.com> References: <87sfvxhrav.fsf@ponder> <874k8bxbit.fsf@gnu.org> <87fsru8l05.fsf@ponder> <87czmy8hr6.fsf@ponder> <87y25kjiwa.fsf@gnu.org> <071f69a4-4e8a-3337-6a84-6ceca5119e6f@philipmcgrath.com> Date: Fri, 19 Nov 2021 21:21:29 -0800 Message-ID: <87tug7jtba.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2600:3c01:e000:267:0:a171:de7:c (failed) Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, 51775@debbugs.gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637385785; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=c0rGpZm2DBf3/9P6ZrLhY0yoAef3gjRqa0ScQHfQbv8=; b=SPYuR4eiCKNbS2ZIEgSTddVOTEh4a97oitIHQb9NIgktXsjQv8W+wP2ChbKKE9WqqAlLFf InMo74765omN9Sqj5FfvmR5fbkFdooq559kQPWkp4X61Sp71v7zzBQR4jUU7Eruy2q40Tx /97nZ8SJuNxq81wBOxp4zjMwnFfO7T0mgg+9qbfbpzSmxvzcdhn5ZHYZIXPd1eQuRhKWlm mr1CEFemuEwGkRqj3fzoIK5mldqrqT83IXZxDQ6YuJlsGgPcYkz2cADQIrPmuEERib9MSw oY0T9+rZVxAL0Nb7Oy8b9GfvewL6EaLe6Lesigt2q6qDZsroJAY5GeoV69dAnA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637385785; a=rsa-sha256; cv=none; b=Z9DptVW9c3iwFRNWC17hgqOoT6LK44iis1kY2tthPz0EygbWBBOGtdQK+7OmXXYkk/kiyv Y5hUh5Z48VUF8XW8WZGJ3bmhDRQwD7GMAAt48u/WNHRgcd00pcbd4gmagPmxn/NHNlfSoa cYnek9TlEZKbJL25d+6NrPoELlqrJEFaOl62Iyjs7Qstwbcg0KUOiLmvZFBunnWaqT7hew 2D4LV9jgUuLDdoW80GHLjDpD95Dwrn6e8q7Bxw5QSaCQ1b6QjoEytJnX2CQ7G0Jsyzlqkp spPY05opGWOvEYnEOxaZTgCZsSHejaVQ4O9Jjixv0Ki8i9I4Ce7UcG/GVSb2aw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.47 Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8EF132D649 X-Spam-Score: -4.47 X-Migadu-Scanner: scn0.migadu.com X-TUID: Jk81QHgW8W+2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-11-19, Philip McGrath wrote: > On 11/19/21 09:54, Ludovic Court=C3=A8s wrote: >> Vagrant Cascadian skribis: >>> So, I guess I'm leaning towards making the guix lint check a little more >>> lenient. >>> >>> Thoughts? >>=20 >> That sounds even better, I=E2=80=99m all for it (changing (guix lint) + = fixing >> the two remaining issues)! Submitted the guix lint change as https://issues.guix.gnu.org/51775 > It might also help to change the warning given by the check. > > When a program called "lint" tells me that something is too long, I=20 > understand that to mean that what I've done is generally considered bad=20 > style, but there might be a very good reason to do it in some specific=20 > case. For example, I might exceed a line length guideline to avoid=20 > inserting linebreaks into a URL. That's a good point! > If instead `guix lint` is telling us about a hard limit that will break=20 > things, I think it should say so clearly. Not sure how to convey succinctly, but here's an attempt at a patch (which ironically also probably makes the line a bit too long in the code): diff --git a/guix/lint.scm b/guix/lint.scm index ac2e7b3841..6464fb751a 100644 =2D-- a/guix/lint.scm +++ b/guix/lint.scm @@ -968,7 +968,7 @@ (define (starts-with-package-name? file-name) max) (make-warning package =2D (G_ "~a: file name is too long") + (G_ "~a: file name is too long and may break re= lease tarball generation") (list (basename patch)) #:field 'patch-file-names) #f)) diff --git a/tests/lint.scm b/tests/lint.scm index 9a91dd5426..d4c3d62aaf 100644 =2D-- a/tests/lint.scm +++ b/tests/lint.scm @@ -509,7 +509,7 @@ (define hsab (string-append (assoc-ref inputs "hsab") (test-equal "patches: file name too long" (string-append "x-" (make-string 100 #\a) =2D ".patch: file name is too long") + ".patch: file name is too long and may break release tarb= all generation") (single-lint-warning-message (let ((pkg (dummy-package "x" live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYZiF4AAKCRDcUY/If5cW qn9WAP92Cl6vJuHzku/IkYq6KFUWRpy1SbqOCwjA14+9mGd75gD/R6K8y0aCBhMU xLDWCkEfHluYfOyHwtVDl6SM1Ep//g4= =aTkp -----END PGP SIGNATURE----- --=-=-=--