Common Lisp package: all test cases pass but 'check' phase fails

Common Lisp package: all test cases pass but 'check' phase fails

[Foo Chuan Wei]

I have submitted patches to add Common Lisp packages "cl-assoc-utils" [1]
and "cl-let-over-lambda" [2]. If tests are enabled in the package
definition of these two packages, all test cases pass, but an error
occurs at the end of the 'check' phase. For example, the error message
for "cl-let-over-lambda" is:

    Summary:
    All 1 file passed.
    Unhandled ASDF/FIND-COMPONENT:MISSING-DEPENDENCY in thread
    #<SB-THREAD:THREAD "main thread" RUNNING {1001860103}>:
      Component LET-OVER-LAMBDA-ASD::LET-OVER-LAMBDA-TEST not found,
      required by #<SYSTEM "let-over-lambda">

In lisp-xyz.scm, I see that the "cl-locale" package has the same problem
with its tests.

Does anyone here know the cause of the error above?


[1]: https://lists.gnu.org/archive/html/guix-patches/2021-11/msg00786.html
[2]: https://lists.gnu.org/archive/html/guix-patches/2021-11/msg00787.html

Re: Common Lisp package: all test cases pass but 'check' phase fails

[Katherine Cox-Buday]

Foo Chuan Wei <chuanwei.foo@hotmail.com> writes:

> In lisp-xyz.scm, I see that the "cl-locale" package has the same problem
> with its tests.
>
> Does anyone here know the cause of the error above?

Without having time to look at the code, but with the hope that this points you in the right direction:

It probably has something to do with the separate test .asd file. The asdf-build-system is probably copying that file to a place asdf can't find it from the production .asd file. You can probably briefly scan the code and get an idea of what's going on:

https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/asdf-build-system.scm?h=master#n1

I will do my best to find some time to answer definitively, but I am particularly busy at the moment. Hopefully someone else can chime in with a more specific answer.

-- 
Katherine

Re: Common Lisp package: all test cases pass but 'check' phase fails

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Katherine Cox-Buday <cox.katherine.e@gmail.com> skribis:

> Foo Chuan Wei <chuanwei.foo@hotmail.com> writes:
>
>> In lisp-xyz.scm, I see that the "cl-locale" package has the same problem
>> with its tests.
>>
>> Does anyone here know the cause of the error above?
>
> Without having time to look at the code, but with the hope that this points you in the right direction:
>
> It probably has something to do with the separate test .asd file. The
> asdf-build-system is probably copying that file to a place asdf can't find it
> from the production .asd file. You can probably briefly scan the code and get
> an idea of what's going on:
>
> https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/asdf-build-system.scm?h=master#n1
>
> I will do my best to find some time to answer definitively, but I am particularly busy at the moment. Hopefully someone else can chime in with a more specific answer.

It looks like these packages are all using the "prove" system for
testing and have a ":defsystem-depends-on (:prove-asdf)" in the system
definition. Maybe prove-asdf is modifying the behavior of asdf in some
way that our asdf-build-system doesn't like.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]