From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id LzULG8PCRmKtEQAAgWs5BA (envelope-from ) for ; Fri, 01 Apr 2022 11:15:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mA+SFsPCRmI1ugAAauVa8A (envelope-from ) for ; Fri, 01 Apr 2022 11:15:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 18250E5DE for ; Fri, 1 Apr 2022 11:15:47 +0200 (CEST) Received: from localhost ([::1]:35490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naDNi-0004ET-9Z for larch@yhetil.org; Fri, 01 Apr 2022 05:15:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naDAp-0008NS-Ts for guix-devel@gnu.org; Fri, 01 Apr 2022 05:02:28 -0400 Received: from [2001:470:142:3::e] (port=50794 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naDAp-0004X4-JZ; Fri, 01 Apr 2022 05:02:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/0PCIcmqLauwChtBmG+TxNn1l17+3f7GtwIsIuANBEQ=; b=lpK5EKZ308eb0BNB+iqp YiSuJDVg2knLnK65BVA6bRL7xpd17JbMhY05b9dIs9P51H/7GXiZFex1WN0MIN7HhEfdxatOJ5ubZ TYM7/lxN+gMoyNywij6Lu4KRxXDMqDg68t0v/JJMA66KvyndeWH/BFio6r+TAM8Hn2YOmQGFtTa8x grNWg0aFQrCWuT+262STTQXSoTfhdj8PDMDZSxLKnyGwUNihqXM8M+u6vr+XPYd0S6Ql2dXMtV49d XZ2BwXeVc4yuT7jytJg6mAExRN6CL/Z0AaSxQ+2SnNJRP8ATr/uY5vR4Pt9jtaZRvTSLUCAoQTd+3 FAyEUoJ6aEpetA==; Received: from [193.50.110.173] (port=38544 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naDAp-0006jx-5k; Fri, 01 Apr 2022 05:02:27 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Josselin Poiret Subject: Re: Deprecating legacy build phase style when cross-compiling vs. native References: <874k3fh3m8.fsf@jpoiret.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 Germinal an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 01 Apr 2022 11:02:25 +0200 In-Reply-To: <874k3fh3m8.fsf@jpoiret.xyz> (Josselin Poiret's message of "Wed, 30 Mar 2022 17:17:03 +0200") Message-ID: <87tubdnplq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648804547; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=/0PCIcmqLauwChtBmG+TxNn1l17+3f7GtwIsIuANBEQ=; b=CZ4NILMz00Pmee7EB1UYG+cAAzyBZnVil1YcC6rj5vs8FnNUghzmpQGckrI0o6URBhVlOM 3Vg+sKnQHmAjzzNPQd0iYr16gsyMRJ0+89ZZXp+9+DfIaiLD2yGhMAKjn3OiqeixRMYffx hXpS7JQI6kVNKes4uSgPwRRJJCoWv8WviKy6+iqZnBKoLAI5TvY3WkrwUND8R3iNrwUCWJ qPXpVFfjXhFgFhhNFwvWTNcqYiZZ8cKVI/3+PRHUEnWLWxMxmjZB5YI7BNLGh6b51G/G7b wlxbCsyxIOyU5+gsiN4Djf+4d6OsuibxtPDN57F2WaRYU4u0zgy7eLFvO1IJpw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648804547; a=rsa-sha256; cv=none; b=c4qMhFLYQtzlLD09iC1CliHeX3JVIKbf2TJCZMKI//mOhpTVvKTvjymQtvgz8Sz+DdWNsl 4OyPGYbAHC6immw2McGQt9K004nSE+Fkt0OxcM0nYwNPuMa402ZaDUn6pYdhwUF+VFmTL+ sr9nQ2/SsmW5lgzvi/XKlfXQTdCglkmUNmd0+3PWAhhbCsrlEmQyeES6sTF2WlgTaeNaV/ EEAZr55doYPVVQtgvQfKL8sMwlxW78u9pZZNqbxQtQCnX68H4Bo4nPvACmfK50fMNkBCR/ qJcO1XUJRn0J0cOzzDbdx7nAkcFPS2QYDoZfQhOtF8Nxepyw7wqISZ+bQ5juMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=lpK5EKZ3; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.57 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=lpK5EKZ3; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 18250E5DE X-Spam-Score: -6.57 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5o199fl63FT1 Hi Josselin, Josselin Poiret skribis: > Looking at guix/build-system/gnu.scm [2], we have gnu-build > vs. gnu-cross-build, which are responsible for native vs. cross-builds. > The former uses with-build-variables to set the legacy build variables > such as %output and %outputs (see the def in guix/gexp.scm), whereas the > latter does not, only doing so manually and so omitting %output. =E2=80=98%output=E2=80=99 (singular) had long been informally deprecated in= favor of =E2=80=98%outputs=E2=80=99 (plural). > This means that packages that were not updated to fit the new style > should all fail to cross-compile. This simple bug could be resolved by > adding %output to gnu-cross-build, however as was argued on IRC this is > now undocumented behaviour and we'd rather switch all packages to the > new style instead. While I 100% agree with this, I think we should have > a uniform deprecation policy for this matter, and that there shouldn't > be such a disparity between cross and native builds. The easiest change is to replace: %output with: (assoc-ref %outputs "out") It=E2=80=99s a simple search-and-replace. The next step would be to use gexps and #$output, but that can be done incrementally over time IMO. WDYT? Thanks, Ludo=E2=80=99.