From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IMQ4JApxoGKEIgAAbAwnHQ (envelope-from ) for ; Wed, 08 Jun 2022 11:51:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QJYpIwpxoGLUkQAAG6o9tA (envelope-from ) for ; Wed, 08 Jun 2022 11:51:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3EE0F17147 for ; Wed, 8 Jun 2022 11:51:06 +0200 (CEST) Received: from localhost ([::1]:40800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nysLB-0005Tf-9B for larch@yhetil.org; Wed, 08 Jun 2022 05:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nysK7-0005SW-J6 for guix-devel@gnu.org; Wed, 08 Jun 2022 05:50:00 -0400 Received: from ns13.heimat.it ([46.4.214.66]:46710) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nysK2-0001Mm-Jm; Wed, 08 Jun 2022 05:49:56 -0400 Received: from localhost (ip6-localhost [127.0.0.1]) by ns13.heimat.it (Postfix) with ESMTP id C99DA30087D; Wed, 8 Jun 2022 09:49:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at ns13.heimat.it Received: from ns13.heimat.it ([127.0.0.1]) by localhost (ns13.heimat.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uXh2Gk6I9DiZ; Wed, 8 Jun 2022 09:49:49 +0000 (UTC) Received: from bourrache.mug.xelera.it (unknown [93.56.171.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ns13.heimat.it (Postfix) with ESMTPSA id 8C7CE30085C; Wed, 8 Jun 2022 09:49:49 +0000 (UTC) Received: from roquette.mug.biscuolo.net (roquette [10.38.2.14]) by bourrache.mug.xelera.it (Postfix) with SMTP id 26A381B69B1B; Wed, 8 Jun 2022 11:49:48 +0200 (CEST) Received: (nullmailer pid 7194 invoked by uid 1000); Wed, 08 Jun 2022 09:49:48 -0000 From: Giovanni Biscuolo To: Arun Isaac , Ludovic =?utf-8?Q?Court=C3=A8?= =?utf-8?Q?s?= , Guix Devel Cc: GNU Guix maintainers Subject: Re: On commit access, patch review, and remaining healthy In-Reply-To: <877d5um1oe.fsf@systemreboot.net> Organization: Xelera.eu References: <87ee07m77w.fsf@gnu.org> <877d5um1oe.fsf@systemreboot.net> Date: Wed, 08 Jun 2022 11:49:47 +0200 Message-ID: <87tu8viix0.fsf@xelera.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=46.4.214.66; envelope-from=g@xelera.eu; helo=ns13.heimat.it X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654681866; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=UhxTRgdeKlh64KQtTNsS6UVOHLOFQNEoSnuPXxVoCEQ=; b=HCJY/E9kIfIO70E1fLQJ9Rp1tdHVGasr469Z/iSV0tPHImE7Ec4so3FWpwmcS99k7UQ6Ot ewiM8HN2vSNUPp5pA+lETge1Ip5EWqlgZt5mFmt9yRddIaCUHLbMMtANSChnbmwwkGjlvJ FVYVJltCa1ofoio9pT66E5WfKwywW/cWdhcpgctRxky4iolebThSMCnDzT6IWRpkXVDzPD 4bBUKNCQI1NzNLEasGtaH4cYgXc1Q1zZ1JkAkpw3lmkDfhGHI2NZBAl9V+Jor8YKpJ/oGx nFt4TMaw3fgA66tEaAw47fIEBfkL/pqpTCajv2T06blynmcOqqHd/wrd+9hDjg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654681866; a=rsa-sha256; cv=none; b=WCon8UH1qX6rfjhjZYcLf6gqH3yhEtF9MUHhS0Wfk/KhBnns4Jcb3fbEM/Y3e1Rb9wByTn Ve65cgX9sLnK6aCH6Ez4eIUggzxTNHEZqYGV3PGOvahTuGrYcK4ReoozVazVhgzGjYFKH2 HtMnVkgoDj+OZWzTLgXjm4+wVP0Jim7YvWwquz1lQ+wyH1AzMzmroEvGJZAhQ5yoV7+bFk vIFrog7cmb5L8JTwIpKpIEJXX+R2Nj7kNHBGW99hBn/NO26axzRz4LDiix+/P9+KTlPcgQ E8Q6rljX5xHO7nNz8Wd3/+xIpcrM/Hloe+HtXnQfBB+kQZErTQ/TzsvA0oNUzw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.71 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3EE0F17147 X-Spam-Score: -4.71 X-Migadu-Scanner: scn0.migadu.com X-TUID: GQgMeE/hhzOy --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Arun, Arun Isaac writes: > Tooling aside, at least for me, I think there is an important emotional > and psychological aspect to patch review. Maybe others share it too. So, > I'll speak up. Thanks a lot for your speak up! > Guix has very high coding standards Do you think other software distribution do have less high coding standards? [...] > but that means that there is a high cost of failure please can you expand on this? What is that cost of failure? > and a pressure to live up to that high standard. This means that even > if I'm 99% sure of a commit, I tend to leave it to others because of > that nagging 1% doubt I have about some trivial aspect of the > patch. The 1% doubt could even be about really trivial things like > indentation or the name of a variable. In other words, perfectionism > causes paralysis. generally speaking I really understand your feeling (the "impostor syndrome" as Ludo' say) but please do not be paralyzed by this feeling, do /not/ have fear to make a mistake, we (pluralis majestatis :-D ) are not here to judge you specifically speaking, IMHO in cases like this you should send an email-reply to that bug (patch) explaining the 1% you are unsure of > This excessive self-doubt is created by feeling like one doesn't > "belong" in the elite community of Guix hackers I undestand there are many meanings of "elite" [1], but if it's an elite it is /for sure/ a very open group of persons [...] Thanks! Gio' [1] https://www.merriam-webster.com/dictionary/elite =2D-=20 Giovanni Biscuolo Xelera IT Infrastructures --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJABAEBCgAqFiEERcxjuFJYydVfNLI5030Op87MORIFAmKgcLsMHGdAeGVsZXJh LmV1AAoJENN9DqfOzDkS67IP/1XN4gmZ8O8bRY8D2/GzPthgx4IEQmrstjw6s5pq QL7fugxLSpTWMqV8rasKFFEF94hwwz+JNQwIOy88lAOmfYbUcBWnnzIGIugtgECn 5HOpj/I9oleR4UbfZe4jdDi+4dwsYJOxfIHkTS4bmXvIR43xveR7OwqCBsna6J7U VjU3glEjnQf5IHbjMQmdVzWTjoyStQd9sxil65pZVaSBhx6OcGserDpwRh2pdGLk q4XohuNUfgfGTup5of5ixMnKFpc+XeD84B1nzlvqUfUPPDWCVNP2eDxxjGl8aDd1 zor0QN7tb15o372Im4F84Rlc8OuT2t9xXJ7/FmSeC0XFredBKQ9avOr38cntyLqe k8MqR3P5gBlGMTLZK6kpmk+DMLEE3FtL7zHxx+0Doqxf9+/ezqAijCpcXPt4HtrT W8ZBshYN3a5SPyDXm+P4INECXEqZgfjwsK8+BsRG3RgVcn5kOos/eog4fF9Gy8AM OQq/u/2YCZc30qreUYt4wYZCbMkyoT71qQdrKWBjBPfg7hkefxgsgQ+Lf7eiD+vZ 1+IzMHHoUbfCrSFIAkMQ+bUWrs2ufjz4TcnfsZZfM59D9TeCQzljGkJ46jXUv+An bnHzoOJ5p01yXXab+vx2KfnKqr9J0u+C0KSf+QT6e8Rv1vvM3ABWapUhsAOPNj1r E4ea =QSN2 -----END PGP SIGNATURE----- --=-=-=--