From: "Ludovic Courtès" <ludo@gnu.org>
To: Vagrant Cascadian <vagrant@debian.org>
Cc: guix-devel@gnu.org
Subject: Re: guix lint false positives and RFC patch
Date: Thu, 03 Nov 2022 16:20:45 +0100 [thread overview]
Message-ID: <87tu3goyia.fsf@gnu.org> (raw)
In-Reply-To: <87leosd8bg.fsf@contorta> (Vagrant Cascadian's message of "Wed, 02 Nov 2022 20:29:39 -0700")
Vagrant Cascadian <vagrant@debian.org> skribis:
> --- a/guix/lint.scm
> +++ b/guix/lint.scm
> @@ -313,7 +313,8 @@ (define (tests-explicitly-enabled?)
> '()))
>
> (define (properly-starts-sentence? s)
> - (string-match "^[(\"'`[:upper:][:digit:]]" s))
> + (string-match "^[(\"'`[:upper:][:digit:]]"
> + (string-replace-substring s "@code{" "")))
An identifier in @code or file name in @file may legitimately start with
a lower-case letter so I don’t think we should try to prevent that.
However, maybe we could change the regexp above to something that
accepts @ or some other non-letter character at the start?
Ludo’.
next prev parent reply other threads:[~2022-11-03 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 3:29 guix lint false positives and RFC patch Vagrant Cascadian
2022-11-03 15:20 ` Ludovic Courtès [this message]
2022-11-03 23:46 ` Vagrant Cascadian
2022-11-04 22:24 ` Vagrant Cascadian
2022-11-05 17:52 ` Ludovic Courtès
2022-11-13 1:54 ` Vagrant Cascadian
2022-11-17 15:03 ` Ludovic Courtès
2023-01-27 17:42 ` Simon Tournier
2023-01-28 21:07 ` Vagrant Cascadian
2023-01-28 21:24 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu3goyia.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).