From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kPm7N/q5r2TlZgAASxT56A (envelope-from ) for ; Thu, 13 Jul 2023 10:46:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YPW9N/q5r2SuiwAA9RJhRA (envelope-from ) for ; Thu, 13 Jul 2023 10:46:50 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91379345A1 for ; Thu, 13 Jul 2023 10:46:50 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=VkrNH6yC; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689238010; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=sUbxJu/WL91mwN1MKYVPy4AEJ69yweCQbI/zcnCntO4=; b=aKJQmlyDl7n9Bb7YrhHfAWq9nZ1tqCMLW1DkQRPGufYWuvcG5uJFDhWS1IWVOQNW9+1IWC np/3E7jIHLzmpdjpJN7tHaSJnlx3r12KywLFBu/v9c8awTKJNyk3ujHkc94j+B1fbXU8Mc MBx77EXeVVF/HccvR2hq2vEDLjy88jN/8/OP0A7BHx+07nZo5kbexhRmQkiYAtGD0n66lj oWW5QlNnseOsnmy+UrBQKZH1QTwPRnlbE0wnRJH3+jjBVLfTlhg6vv9yYystiZgFFTvW/F F9ixvbS6YDf31Na53GGeLF/9QN+3Mrlk3kHxZa8qIq7CKT4SWIPoK09NZs0L1w== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=VkrNH6yC; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=2; s=key1; d=yhetil.org; t=1689238010; a=rsa-sha256; cv=pass; b=jbRKsRYP1JjaTQ3ZgtG+2zHKLFP4Uq+YkoXkbrCtrWWzHx6P7ZSToyrk4HW3lZXMNfXQqE MPpG3Aa+HVFs2g4dao4RCCnzEcjSQCsnPJlegwczz7MILekubIJZWrcgLzcddUvEnim3ur UGiwqyM1VidW6pFdK5Twio6aBZzOccWUkmYOA4thGZQUefyBOWMKzKojjqsmBbG/jDjMlD A1KwDQzSP90C2PoG3KrzI8I+PUYI4dnQ5qTx5gm8UEr2KmmSVfOefANESNQZ5GqJZ3EgR3 yEKxC5iAjWwzKrzSGfjw6AJx35aWnS678SAK5hOzcP4l3WX9e0yOiOpIrO+Gmg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJrxX-00086L-N3; Thu, 13 Jul 2023 04:46:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJrxN-0007sc-3p for guix-devel@gnu.org; Thu, 13 Jul 2023 04:45:53 -0400 Received: from sender4-of-o50.zoho.com ([136.143.188.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJrxJ-0007IJ-Ld for guix-devel@gnu.org; Thu, 13 Jul 2023 04:45:48 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1689237940; cv=none; d=zohomail.com; s=zohoarc; b=By184XsJDGJZNu81AZKjqs9U9iwUL+9Z/2yiX9SE+uJEHlSVkNyUzk7lUADgd/Be/dYeR5i/oe8r/BXBz2KSkV8yUK+6sf0lsokmCUhiv0SqRkwdAaPNiJ1urjdNrrSzB2WlIOnWVar7Y38aTSAQntKLllBtvsFJLvnZW0tUFkU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689237940; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=sUbxJu/WL91mwN1MKYVPy4AEJ69yweCQbI/zcnCntO4=; b=C1LwkXiNWiNxUwnKdd+aIpniI5OJhCNaTG58aMFZZMyNn7MLyDgzao0yM7OtGFhbrdlxaFAc1hvvLpgYTJlENMdBNjXxbf85Fmm3Z+v/SGK/nDRfXzsKpcOFKrKXhf36dhbRmNdNatakX4+Q+sTvMee5IaR26t2dvLSGvoCky4U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1689237940; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=sUbxJu/WL91mwN1MKYVPy4AEJ69yweCQbI/zcnCntO4=; b=VkrNH6yCNrlpIqzL/X9loeSghR6N/NIjmofDNAcyYBEfBxijd0/i+67bzmtCW4S6 soFSOlAWR1zcD5ZpoLNXbSlKNwD9Qg/pIukGW1+IFFZlkAZnXfHFf5vIkBzQfAgfUZx LFP05jjBcgK8EqG4Rath+GrlRiPENO5HaP6Z8204= Received: from localhost (215-111-142-46.pool.kielnet.net [46.142.111.215]) by mx.zohomail.com with SMTPS id 16892379385181007.2712114043298; Thu, 13 Jul 2023 01:45:38 -0700 (PDT) References: <873520tgi4.fsf@elephly.net> <87sf9z5221.fsf@fsfe.org> <877cr4i9u8.fsf@elephly.net> User-agent: mu4e 1.10.3; emacs 28.2 From: Ricardo Wurmus To: Jelle Licht , guix-devel@gnu.org Subject: Re: npm has irreproducible install behavior Date: Thu, 13 Jul 2023 10:41:14 +0200 In-reply-to: <877cr4i9u8.fsf@elephly.net> Message-ID: <87ttu8gpxs.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.50; envelope-from=rekado@elephly.net; helo=sender4-of-o50.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 91379345A1 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -10.04 X-Spam-Score: -10.04 X-TUID: gtECPuZhkoxo Ricardo Wurmus writes: > Hi Jelle, > >>> I=E2=80=99ve tested this little addition to the build phases of node-lt= s on an >>> affected system: >>> >>> --8<---------------cut here---------------start------------->8--- >>> (add-after 'install 'do-not-ignore-links >>> (lambda* (#:key outputs #:allow-other-keys) >>> (with-directory-excursion >>> (string-append (assoc-ref outputs "out") >>> "/lib/node_modules/npm/node_modules") >>> (substitute* "pacote/lib/fetcher.js" >>> (("\\/Link\\$\\/.test\\(entry.type\\)") "= false") >>> (("\\/File\\$\\/.test\\(entry.type\\)") >>> "/(File|Link)$/.test(entry.type)")) >>> --8<---------------cut here---------------end--------------->8--- >> >> The proposed change seems fine to me, provided our QA shows a pretty >> green button at some point. Could you send a patch that also includes a >> comment referencing the upstream bug report? > > I changed it to patch node-tar instead, because the patch to fetcher.js > would cause *some* files to be copied to the wrong location. > > I=E2=80=99ll send the updated patch to guix-patches today. Here=E2=80=99s the patch set: https://issues.guix.gnu.org/64592 The first patch is to clean up the snippet while we=E2=80=99re at it. The second changes the behavior of node-tar, so that files with hardlinks are not treated any different from files without. --=20 Ricardo