From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SM3oOEPV7GTzvgAA9RJhRA:P1 (envelope-from ) for ; Mon, 28 Aug 2023 19:11:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SM3oOEPV7GTzvgAA9RJhRA (envelope-from ) for ; Mon, 28 Aug 2023 19:11:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A936C59EF4 for ; Mon, 28 Aug 2023 19:11:31 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=OdUXNuSg; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693242691; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=MIW1T2UOV9z808DKQ1LkICou6266GknpjkBDwLRDWvY=; b=gisXLP+xrY9WpN51YoSTGWzu+jTCvWSUNGXsnIVx8PNfq1zZ3IFTsj+cVZfJjVPAbtBedR LJTqQnekiDSuJq+w9XvtWEGvSHfIDjFG9H5Kjkbk7NmqZfxC0ocXDgcRBWINOXfBeknXeG TwPIZIjgG5/r0v9R+U8PaMauIZRLK8lwn59lctxmlHXz3v5S/8KP3myaZFjl4yRpTnOkby NoQnmHxAQBJULnJ5EF8IxyMuHKPF+Ww1XN6Czrqdh9UmB95zSH2/6XhW21tJPSF+kG1y5m 4WDpc1bCgBErKFtU2kXe6gmgL28iX6snhjzUUQ3/8yGNyIBOk5lqZgsPLmKCDA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693242691; a=rsa-sha256; cv=none; b=GzkUCPhQr+3ObydSOLldiWV2YJwWS8KiY099tbcq4oPEVq59gvWLusIKmf2Hky/W9uw4p9 8VZ6f4X9DRA4+fVWzNBiYup0JtPkAat/nJ/16SfryO50GdScwZG3W+k5wAwKztkSJ2MzhD +YqUj8FA/H4x5vRdJqIltoUaHWOFbHRfaH6LbKTSbbAnIG6cn+bs60POj0duLk1bOQ7SEJ jGStMCICS/20Jqnepf/syDjURZeD5ngX7oQS67us+Sil2VXoZYhHh1lX19KCtbxjRsvRqV 1Eq7BHIACkj5uEaaF+OHgJ8Q1LvqxbqyUcbWlluNglu/rgsXRaETrSDQIdzU4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=OdUXNuSg; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qafky-00051L-Cs; Mon, 28 Aug 2023 13:10:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qafkv-00050R-Oo for guix-devel@gnu.org; Mon, 28 Aug 2023 13:10:25 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qafkt-00054K-5O for guix-devel@gnu.org; Mon, 28 Aug 2023 13:10:25 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3175e1bb38cso213240f8f.1 for ; Mon, 28 Aug 2023 10:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693242622; x=1693847422; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=MIW1T2UOV9z808DKQ1LkICou6266GknpjkBDwLRDWvY=; b=OdUXNuSgA0JxcVYPayyQggNhrpuA5tN29KZYYTg6Deo0yPbxX359nZpUP1ebxiwQVQ O/HSVtjUtohxN7gZqxElMlVainlenGj8rsjhFbjIcH8kJdcwYPHGqyazsoyRTsXMA0mM AVZmQ9X3L8HL8t6XtEjinNV7mC7WMMyCTbGX1Fy9qvr58atieINpZid39Afmcvui1F8v /CfRhzCRvcaoG5Zsp5qHKuOnk8GM+nGu2Uu0GA/lNjABsUknPxX9ZBbgQiGwmt1BZlLQ xVO5gB/rqShAElFxIMTb7u6rvIUMj072ZdqVLsjtgT8y0nimuMup6NbD78pS3Mkx8oon m8Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693242622; x=1693847422; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MIW1T2UOV9z808DKQ1LkICou6266GknpjkBDwLRDWvY=; b=dMDnNs9RBBZ/IOyDJbuYqxSjrNAeu96VZkqVKIz8xJfvRlznr517CX2OWUJbEH5ZnR 8erGdnRYziZ7CKuPwA0LN0yGIyEZHSD8/pQ1hCGPGHuI2uTmmhT3PiABnXa8NHvpjgDG M3s4KOZTGxizEZcnY7mrpGLemVXzw1WMJyI2TZc/CrAmq0Jzmhrza75xn+UbY5nW2Ua5 42fjGXoOGmFtA2PpiNk+V+SaUuZ7y62VJUpJOQpodtFL2di1mHVl5X2t9DKLEon06fYg wUbua5JtQWylmGKfIA1wUSJKpzJNJwit6nF0EzEDStstqmlTtZkar5EDrXDjOgSuJWU7 5r4A== X-Gm-Message-State: AOJu0YzHqhfw14Z7i9ICBoxUOXfEmk0IwKnEp0yd/6qKn4ll9Yq1hc6Y k95QlS3dxAJEqmNYWBsLDoxGtdie6is= X-Google-Smtp-Source: AGHT+IFtjPatyt8s9LqUpiQKqikDhyU2jpgGgZCLs70r9mrUPPe2PcUCHqiBmeGCXTUZfYuDYR3o9A== X-Received: by 2002:adf:f892:0:b0:317:7238:336a with SMTP id u18-20020adff892000000b003177238336amr19254215wrp.5.1693242621760; Mon, 28 Aug 2023 10:10:21 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id n20-20020a7bc5d4000000b003fbca942499sm14552446wmk.14.2023.08.28.10.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 10:10:21 -0700 (PDT) From: Simon Tournier To: Adam Faiz , guix-devel@gnu.org Subject: Re: (computed-origin-method) and (origin)'s file-name field In-Reply-To: References: Date: Mon, 28 Aug 2023 14:45:50 +0200 Message-ID: <87ttsjpc75.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.61 X-Spam-Score: -2.61 X-Migadu-Queue-Id: A936C59EF4 X-Migadu-Scanner: mx1.migadu.com X-TUID: yHd3rdSxNu0M Hi, On Sun, 27 Aug 2023 at 20:25, Adam Faiz wrote: > Must the 'computed-origin-method' workaround be solved by adding the > renaming capability to snippets? > > Why couldn't the file-name field of the source origin be used to > rename it? > > If it's because the upstream source might be confused with the > liberated version, couldn't a comment above the snippet clarify that? To my knowledge, computed-origin-method predates current snippet features and I think no one has taken the time to see if the same could be achieved. Well, this computed-origin-method workaround is used 5 times: --8<---------------cut here---------------start------------->8--- 5 candidates: ./gnu/packages/gnuzilla.scm:569: (method computed-origin-method) ./gnu/packages/gnuzilla.scm:1198: (method computed-origin-method) ./gnu/packages/linux.scm:375: (method computed-origin-method) ./gnu/packages/emacs-xyz.scm:8788: (method (@@ (guix packages) comp= uted-origin-method)) ./gnu/packages/emacs-xyz.scm:29603: (method (@@ (guix packages) compu= ted-origin-method)) --8<---------------cut here---------------end--------------->8--- I bet that =E2=80=99snippet=E2=80=99 could be used for the two Emacs packag= e cases. Another story. :-) That=E2=80=99s said, =E2=80=99computed-origin-method=E2=80=99 delays what = =E2=80=99snippet=E2=80=99 does not, IIRC. For references, Mark=E2=80=99s =E2=80=93 who introduced computed-origin-met= hod back on 2019 =E2=80=93 message is [1]. Mark=E2=80=99s comment [2] makes clear that= this workaround needs to be somehow revisited, I've always viewed 'computed-origin-method' as a temporary hack to work around limitations in the 'snippet' mechanism. Most importantly, last I checked, it was not possible for a 'snippet' to produce a tarball with a different base name than the original downloaded source. I consider it a *requirement* for the 'icecat' source tarball and it's unpacked directory to be named "icecat-=E2=80=A6" and not "firefox-=E2=80=A6", and similarly= for 'linux-libre'. and the lengthy thread in patch#50620 [3] contains some discussions for improving the situation. Because the number of packages requiring computed-origin-method is very low, there is few progress. One good start would to collect and extract all the ideas from #50620. Cheers, simon 1: Re: =E2=80=98computed-origin-method=E2=80=99 for IceCat and ungoogled-ch= romium Fri, 30 Aug 2019 18:41:49 -0400 id:87woeuwa0n.fsf@netris.org https://yhetil.org/guix/87woeuwa0n.fsf@netris.org https://lists.gnu.org/archive/html/guix-devel/2019-08 2: https://issues.guix.gnu.org/50515#3-lineno61 3: https://issues.guix.gnu.org/50620#12