From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id aG5GAfmF+2QIbgEAG6o9tA:P1 (envelope-from ) for ; Fri, 08 Sep 2023 22:37:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aG5GAfmF+2QIbgEAG6o9tA (envelope-from ) for ; Fri, 08 Sep 2023 22:37:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 042CA4B0D8 for ; Fri, 8 Sep 2023 22:37:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=eWzOgIes; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694205433; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=yPlbwtJLaHMY1jCjO7yOB8zGxWrrpBrlLbKNGKsRVwU=; b=V/oACDL0z+QRXTaM80wpuSP5VG/4MWkBJAiDdwOSv7cteG9x9Fazo8mCPyTc6UsvVI/Iof OwEKmss1NHfNgYePx/kkHlWcFQPQlyqSF9bw9SrXuvt0cgjs2Ekt509o8/fVUza1dd8mEa 418wf5Ql4q1vw1YNwPHcUVxH0JUfvB5F/tpW/EvjHCb8HW/vQ6GxFntjkvYpNSvWcpu056 gAqN4OaI/DfZDigkbxPV/CLtGgz7YRHN7HqYZE9FzpHfywmPnGiPIy/gIhdthDZBuKOkD/ iXZh0quN65JVNdW+yzQzZXXOE1HZ2Lv3lY1h+Xm4d4t/PHpGyLeXf91tMAidew== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=eWzOgIes; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1694205433; a=rsa-sha256; cv=pass; b=RPSJakq4tiRHjQQ8Q/XArehJQJVfEIP6/CQ2umqz8ZYY7OcBQv94QBRt844SYIK/27GOli 6e98ssr7QVc9XIx3pUbQOu4rDoxcxQbByj9IadEypKrxQZA7nCmMzC7oin2UP0U0HSN+8G 6FDlqvBBbRoGKlXGpkxBfs7s7bwSgqxdh8Uh/0neHhbQoHpq3CG2ohgV/62jg2/OEqHqaU /xQ3z2eY+GqVzzPzA1v3jd8swCD9+rRd8T+HR1LEB/9ipIO/gwoW420msj6gj+rJPg3P8O Eq6AZGcMI2hQLtT0EtpmmhSzZreYytHpGoJoDCbBkaMvGyX1g6ZOxu7xY+LwiQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeiDS-0007y8-5M; Fri, 08 Sep 2023 16:36:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeiDQ-0007wT-U1 for guix-devel@gnu.org; Fri, 08 Sep 2023 16:36:32 -0400 Received: from sender3-of-o58.zoho.com ([136.143.184.58]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeiDO-0002iO-E7 for guix-devel@gnu.org; Fri, 08 Sep 2023 16:36:32 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1694205387; cv=none; d=zohomail.com; s=zohoarc; b=IT1Z6Zz0ag1s3hY1gonSAM6c+hCVmmpMHhuk/u+IE6kpYmAsEnp0IUtiddxvsdqDP1yXQLK+yOhF//W9Q9PMcDYoyXOP3HbnoQc+FHueVqlvJybEzFUHS3ZLpl7Or3UFb8ANMEKGiYr4hzhIVxB3EkzaO479Gk+C/qfbUuS+cKw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694205387; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=yPlbwtJLaHMY1jCjO7yOB8zGxWrrpBrlLbKNGKsRVwU=; b=GOjoPQ0fNtX5HZhxTtQJ9MUbxbxEGd4/Et8jVJYcWec7I/F57L5WNa/yQD7onqsKrGCAjs8r5RVw1rBUL6e+GB4MbdiHfMmpYFRL++gfdzQB6meDP4odqo8QF6x1KoIIgrwH/+TurLur4rt5wbdMMzmkNhdYG0C+6vTzH9w/i5Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1694205387; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=yPlbwtJLaHMY1jCjO7yOB8zGxWrrpBrlLbKNGKsRVwU=; b=eWzOgIesYccbZp4i5mlSTrpGAF3e3OvBKEg10RoPwu/mVLSyX/dphYzqbjJ7Iw48 oqlpxWGBRqibE3iWbWzYJ5kctPfpF7ej4JUMD8VLNuQHZ68bvoXdSCa/F72wBLDpPpC EpDRvp5DAsS0dWWK4x3R8mg7CyjZYZHLYc+oh2S0= Received: from localhost (133-122-142-46.pool.kielnet.net [46.142.122.133]) by mx.zohomail.com with SMTPS id 1694205385167314.41137838649263; Fri, 8 Sep 2023 13:36:25 -0700 (PDT) References: <87sf7o67ia.fsf@elephly.net> <9269133a74e06bfc5ee5bfeee0342ba2f5beaeb1.camel@gmail.com> User-agent: mu4e 1.10.5; emacs 28.2 From: Ricardo Wurmus To: Liliana Marie Prikler Cc: Attila Lendvai , Andreas Enge , Katherine Cox-Buday , guix-devel@gnu.org Subject: Re: How can we decrease the cognitive overhead for contributors? Date: Fri, 08 Sep 2023 22:24:06 +0200 In-reply-to: <9269133a74e06bfc5ee5bfeee0342ba2f5beaeb1.camel@gmail.com> Message-ID: <87tts44d2y.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.58; envelope-from=rekado@elephly.net; helo=sender3-of-o58.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 042CA4B0D8 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -5.17 X-Spam-Score: -5.17 X-TUID: nXMRMiJU82a7 Liliana Marie Prikler writes: >> On Github, Pull Request branches are like our WIP branches.=C2=A0 They a= re >> how we arrive at acceptable changes.=C2=A0 Picky people like me would th= en >> go back and write new atomic commits for the effective diff, but in >> my role as a reviewer I usually rebase, squash, and merge. >>=20 >> This workflow is more familiar to some and alienating to others, but >> both of these workflows would work fine for Guix.=C2=A0 But today our >> tools can only accommodate *one* workflow.=C2=A0=C2=A0 > I'd imagine that rebase, squash and merge would exacerbate the workload > on the committer side and I think that most popular projects on those > forges already experience similar effects to us despite folks just > merging the requests as-is and in part even getting paid by big tech > for doing so. Look, I=E2=80=99m relating merely my work experience here as someone who regularly reviews pull requests on Github. Github has buttons for =E2=80=9CRebase and merge=E2=80=9D, =E2=80=9CSquash and merge=E2=80=9D, and= =E2=80=9CCreate a merge commit=E2=80=9D, so that part is automated. I=E2=80=99m not saying that this is the workflow we should adopt. I=E2=80= =99m saying that these platforms =E2=80=94 for better or worse =E2=80=94 encourage *dif= ferent* workflows, and for some this is what they are most comfortable with. Must we force a single workflow on everyone, even if our track record in reviewing and merging doesn=E2=80=99t clearly show that our way is superior? Recall that the reason for my response at this point in the thread is your statement: > Hiding obsolete versions of a > pull request is in practice implemented either by pushing more commits > on top of the existing one, often with dubious commit messages or by > force-pushing a branch, neither of which is an acceptable solution for > Guix. I=E2=80=99m trying to convey that this workflow is similar to how we would = push to wip-* branches and informally discuss open issues out of band. (And even in that scenario, we are rather limited by the way our shared repository with all-or-nothing permission management works.) --=20 Ricardo