From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WAGkFtKzCWVtVwAA9RJhRA:P1 (envelope-from ) for ; Tue, 19 Sep 2023 16:44:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WAGkFtKzCWVtVwAA9RJhRA (envelope-from ) for ; Tue, 19 Sep 2023 16:44:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C064C588 for ; Tue, 19 Sep 2023 16:44:34 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=OBqaPIjl; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695134674; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=8T2kdzOGwHKamCjo9hN2Cv51N1SnkhPrujUmPkF16Js=; b=E8MvhWIHnPTIfaVuyW83lpJoIl66o4WZUhuNkwg7UBJAW5mW6hQQ52y+m5TLMUwGd36Uhh ypVq08ROYLjobmrPYiZX9s8SEKOfj0KbAj+042rNNPS6qf0b1Xm430sVAy9WdoPIzlIBbf WwM0HZct20lWtl2Qlc2cw8XyAYEq0xRAWkvGeb0n3Ur4W1R8aduS/qCuMaRNPRGXbX4a8g fcpoPug30S6rsUCEFJJXg2L17Tr7eWjvcJ7tzSNNk/8zwgdbe8vnTrLMEikkV57xgcljMl IPTGLThSnznnjhT56w+QwtdNLV328pdsV+9KcGiLyrgwc5oVRgctX2ljFgQbhA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695134674; a=rsa-sha256; cv=none; b=jCHSx16c/rqrfWTXC7uxjtCrvWsdhOruPlSluQqPfoAfvaPMUvkNEormW0ZrVTdXHoYJ7E bwWCtLaDPSa2SX5a/Mc4DHvyCeHmmIqmAv6Zej/+GCC3peBWkRxZvggAq0OH7am4O5MGGG J94bctYKHJSUS0+DBusDb8GTgBhRZQ8w+jXNKTQeCF6jUIk/bFVqdSaclgCB5esceV68Qs US/6UwlhYAvChRFW8UGcFSnq4/y5CcbDQUhlIeJ8VD/SH5DIcLnRgKPRFME11tVuwt40tM 82Xyy76HVwtshUc2pMKePTqwPHnIi6ZwSsbobM4my6ullF55nqL433BPXYO0Lw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=OBqaPIjl; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qibxR-0000Ti-FL; Tue, 19 Sep 2023 10:44:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qibxM-0000Sf-Oc for guix-devel@gnu.org; Tue, 19 Sep 2023 10:44:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qibxM-0001XJ-FV; Tue, 19 Sep 2023 10:44:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=8T2kdzOGwHKamCjo9hN2Cv51N1SnkhPrujUmPkF16Js=; b=OBqaPIjlD5xuhjGYh3dN yBfoswic0M2ZSfh3+b5FzPfB5P52hcSFTCxMuEmS/c2H40fK8M1k9CnXJrtxK3ujDlKM7+TIhTLv6 ogUVnL9LXBdqt+TJebF6mVJUjegvGmXWej9/QjQAS7vNI/q3JRkhCtL4X8trmfm1vHHXfgoADY1Md ks9HIa/Js0FEb/+v9TyRRAYrR+Kz4IVBCbBw9cyqRUzWVfF2on5mVvrFPKE8sounuGuJ3JI/2dBRh g7lQDBylfb1FXFBjwvIkkIk+7MT8AhfOzl6/hKxDCesi8+Xb3/QLTv3qOrCL4zcwlIDp/7xq2ArB9 WyMGKUM9jCoVbw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Cc: guix-devel@gnu.org, 65866@debbugs.gnu.org, Maxim Cournoyer Subject: Re: bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts References: <871qf4ivsr.fsf@gmail.com> <87r0n4wp0d.fsf@gmail.com> <878r987l5t.fsf@gnu.org> <87wmwp8rxy.fsf@gmail.com> <87wmwnh9fe.fsf@gnu.org> Date: Tue, 19 Sep 2023 16:43:34 +0200 In-Reply-To: (Simon Tournier's message of "Mon, 18 Sep 2023 16:45:00 +0200") Message-ID: <87ttrqcjft.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.48 X-Spam-Score: -9.48 X-Migadu-Queue-Id: 0C064C588 X-Migadu-Scanner: mx0.migadu.com X-TUID: rxueOoq75ZSn Hi Simon, Simon Tournier skribis: > On Mon, 18 Sept 2023 at 15:56, Ludovic Court=C3=A8s wrote: > >> Anyhow, how about this plan: >> >> 1. Merge with the hard Git >> dependency. > > Is #65866 fixing bug#63331 (Guile-GnuTLS/Git circular dependency) [1]? Yes, as written in the cover letter. [...] >> 2. When libgit2 1.7 with shallow clones is available in Guix, work on >> a patch to use Guile-Git for clones and evaluate it. > > ...we could also suggest to continue and have a complete fix of #63331 > before merging #65866. Sorry, I don=E2=80=99t understand. As I wrote in the cover letter, this pa= tch series is the complete fix for . > It avoids to introduce a hard dependency which will be difficult to > remove and let the time for this evaluation of libgit-2.1.7, no? What this patch series sets in stone is =E2=80=9Cbuiltin:git-download=E2=80= =9D and its semantics. Its implementation can change over time though: it can switch to libgit2, to OCaml-Git, or anything that pleases us. These are implementation details not visible from the outside. >> As I wrote, as an example, I don=E2=80=99t think that there could be a p= ractical >> implementation of (guix git-authenticate) shelling out to =E2=80=98git= =E2=80=99. > > [...] > >> PS: I don=E2=80=99t buy the =E2=80=9Clibgit2 will disappear from Guix=E2= =80=9D argument because >> it=E2=80=99s not a natural phenomenon that we=E2=80=99re observing b= ut a willful >> construction. > > As I wrote elsewhere, Git-Annex (or Magit) are shelling out to 'git', > IIRC. Well, personally I do not consider that Git-Annex is slow or > that Git-Annex does not implement features as complex as (guix > git-authenticate). > > After reading [2], > > I cannot imagine a viable implementation of things like =E2=80=98com= mit-closure=E2=80=99 > and =E2=80=98commit-relation=E2=80=99 from (guix git) done by shelli= ng out to =E2=80=98git=E2=80=99. > I=E2=80=99m quite confident this would be slow and brittle. > > wolf came 3 days later [3] with a first rough implementation for > 'commit-relation' using Git plumbing which is much more faster than > the one implemented with Guile-Git. Yes, point taken. It=E2=80=99s not so much about whether Git-Annex is =E2= =80=9Cless complex=E2=80=9D, it=E2=80=99s about the level of integration needed. But = you don=E2=80=99t have to take my word for it. We=E2=80=99ve spent lots of words on the issue of a dependency on Git, and = yet this patch series doesn=E2=80=99t actually change much in that regard: =E2=80=98git-fetch=E2=80=99 already uses Git. I suggest that we focus on the various sub-problems we=E2=80=99re trying to solve without losing sight of the big picture, yet without conflating them all. Ludo=E2=80=99.