From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: Romain GARBAGE <romain.garbage@inria.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH Cuirass v2] cuirass: Fix handling of SPECIFICATION-NAME.
Date: Mon, 17 Jun 2024 17:24:35 +0200 [thread overview]
Message-ID: <87tthr618s.fsf@inria.fr> (raw)
In-Reply-To: <20240617150242.18491-1-romain.garbage@inria.fr> (Romain GARBAGE's message of "Mon, 17 Jun 2024 17:02:42 +0200")
Romain GARBAGE <romain.garbage@inria.fr> skribis:
> Fixes a regression introduced in
> 1da873b0e23eceb3c239dd6dc6781debf23bec63, where the NAME field of the
> SPECIFICATION record type is forced to be a symbol as stated by the
> documentation.
>
> * src/cuirass/base.scm (jobset-registry): Handle SPECIFICATION-NAME as a
> symbol.
> * src/cuirass/http.scm (body->specification, specification->json-object, url-handler): Handle SPECIFICATION-NAME as a symbol.
> * src/cuirass/templates.scm (specifications-table, specification-edit):
> Fix template generation.
Applied with minor tweaks to the commit log. Thank you!
Ludo’.
prev parent reply other threads:[~2024-06-17 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 15:02 [PATCH Cuirass v2] cuirass: Fix handling of SPECIFICATION-NAME Romain GARBAGE
2024-06-17 15:24 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tthr618s.fsf@inria.fr \
--to=ludovic.courtes@inria.fr \
--cc=guix-devel@gnu.org \
--cc=romain.garbage@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).