From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] guix package: Add '--delete-generations'. Date: Tue, 24 Sep 2013 14:50:30 +0200 Message-ID: <87siwu9yeh.fsf@gnu.org> References: <87vc2o4qwc.fsf@gnu.org> <87y57kljro.fsf@karetnikov.org> <87hae81uvo.fsf@gnu.org> <87li2oslzh.fsf_-_@karetnikov.org> <878uyo60gp.fsf@gnu.org> <877ge7onje.fsf@karetnikov.org> <87eh8ftuii.fsf@gnu.org> <8738ouu1l2.fsf@karetnikov.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOS9S-0004RC-MI for guix-devel@gnu.org; Tue, 24 Sep 2013 08:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOS9M-00087Z-Up for guix-devel@gnu.org; Tue, 24 Sep 2013 08:55:38 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:57045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOS9M-00087O-BW for guix-devel@gnu.org; Tue, 24 Sep 2013 08:55:32 -0400 In-Reply-To: <8738ouu1l2.fsf@karetnikov.org> (Nikita Karetnikov's message of "Tue, 24 Sep 2013 11:21:29 +0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Nikita Karetnikov Cc: guix-devel@gnu.org Nikita Karetnikov skribis: >>>>> I had noticed that =E2=80=98--roll-back=E2=80=99 doesn=E2=80=99t outp= ut anything with >>>>> =E2=80=98--dry-run=E2=80=99, so I implemented =E2=80=98--delete-gener= ations=E2=80=99 similarly. Maybe >>>>> it would be better to print something. WDYT? > >>>> Agreed (in a separate patch.) > > I don=E2=80=99t think that I=E2=80=99ll have time for this before the rel= ease. I=E2=80=99d > like to be able to test the MIPS binaries. OK, no problem. >>>> =E2=80=9CDelete the generations matching @var{patterns} or ... when om= itted.=E2=80=9D > >>>> Or what actually? I would expect it to delete all the generations but >>>> the current one when PATTERN is omitted, right? > > OK. Should it delete the current generation when it=E2=80=99s specified > explicitly, e.g., =E2=80=98--delete-generations=3D5=E2=80=99?=20=20 Yes. > What about other patterns? It should do what the pattern says, including removing the current generation. My only concern was about the behavior of =E2=80=98--delete-generations=E2= =80=99 without any pattern, which should not remove the current generation IMO. >>>>> +(define (link-to-empty-environment generation) >>>>> + "Link GENERATION, a string, to the empty environment." > >>>> s/environment/profile/ maybe? (I know there are other inconsistencies >>>> in these files.) > > OK. > >>>> Ideally this factorization would go in a patch of its own, before the >>>> one that adds --delete-generations. Is that doable for you? > >>> I think so. > > Sorry, I=E2=80=99m not sure what have to be changed. (I=E2=80=99ve just = looked > through the module.) Do you have time to work on this? Nothing has to be changed; it=E2=80=99s just that I=E2=80=99d prefer to put= the bits that introduce =E2=80=98link-to-empty-environment=E2=80=99 in a separate pa= tch, for clarity. I could do it, but it may be easier for you to do it, no? Thanks, Ludo=E2=80=99.