[PATCH] gnu: emacs: Add more inputs: giflib, libice, libsm, alsa-lib

[PATCH] gnu: emacs: Add more inputs: giflib, libice, libsm, alsa-lib

[Mark H Weaver]

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]

This patch adds more features to our emacs, including GIF support and
sound support.

     Mark


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: [PATCH] gnu: emacs: Add more inputs: giflib, libice, libsm, alsa-lib --]
[-- Type: text/x-patch, Size: 1875 bytes --]

From 4166b5b6eda81db04f9b2c491719877545575060 Mon Sep 17 00:00:00 2001
From: Mark H Weaver <mhw@netris.org>
Date: Fri, 21 Feb 2014 04:48:22 -0500
Subject: [PATCH] gnu: emacs: Add more inputs: giflib, libice, libsm, alsa-lib.

* gnu/packages/emacs.scm (emacs): Add 'giflib', 'libice', 'libsm', and
  'alsa-lib' inputs.  Remove "--with-gif=no" from configure arguments.
---
 gnu/packages/emacs.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cecfd60..87c4e89 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -33,6 +33,8 @@
   #:use-module (gnu packages libjpeg)
   #:use-module (gnu packages libtiff)
   #:use-module (gnu packages libpng)
+  #:use-module (gnu packages giflib)
+  #:use-module (gnu packages linux)
   #:use-module ((gnu packages compression)
                 #:renamer (symbol-prefix-proc 'compression:))
   #:use-module (gnu packages xml)
@@ -54,8 +56,7 @@
     (arguments
      '(#:configure-flags
        (list (string-append "--with-crt-dir=" (assoc-ref %build-inputs "libc")
-                            "/lib")
-             "--with-gif=no")                     ; XXX: add libungif
+                            "/lib"))
        #:phases (alist-cons-before
                  'configure 'fix-/bin/pwd
                  (lambda _
@@ -73,7 +74,7 @@
        ("gtk+" ,gtk+-2)
        ("libXft" ,libxft)
        ("libtiff" ,libtiff)
-       ;; ("libungif" ,libungif)
+       ("giflib" ,giflib)
        ("libjpeg" ,libjpeg-8)
 
        ;; When looking for libpng `configure' links with `-lpng -lz', so we
@@ -83,6 +84,9 @@
 
        ("libXpm" ,libxpm)
        ("libxml2" ,libxml2)
+       ("libice" ,libice)
+       ("libsm" ,libsm)
+       ("alsa-lib" ,alsa-lib)
        ("dbus" ,dbus)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
1.8.4

Re: [PATCH] gnu: emacs: Add more inputs: giflib, libice, libsm, alsa-lib

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> From 4166b5b6eda81db04f9b2c491719877545575060 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Fri, 21 Feb 2014 04:48:22 -0500
> Subject: [PATCH] gnu: emacs: Add more inputs: giflib, libice, libsm, alsa-lib.
>
> * gnu/packages/emacs.scm (emacs): Add 'giflib', 'libice', 'libsm', and
>   'alsa-lib' inputs.  Remove "--with-gif=no" from configure arguments.

OK to push.

Out of curiosity, what does it do with ALSA?  I use EMMS, but it just
calls out to ogg123 & co.

And libICE and libSM?

Thanks,
Ludo’.

Re: [PATCH] gnu: emacs: Add more inputs: giflib, libice, libsm, alsa-lib

[Mark H Weaver]

ludo@gnu.org (Ludovic Courtès) writes:
> Out of curiosity, what does it do with ALSA?

Emacs has the ability to play sounds internally.  See
'play-sound-internal' and 'play-sound'.  I guess it's mostly
useful for very short sounds like beeps and alerts, where it's
good to minimize the delay before the playing begins.

> And libICE and libSM?

To be honest, I'm not sure what they are used for, but I noticed that
the configure script looked for them, and the final emacs is linked with
them.

      Mark

Re: [PATCH] gnu: emacs: Add more inputs: giflib, libice, libsm, alsa-lib

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>> Out of curiosity, what does it do with ALSA?
>
> Emacs has the ability to play sounds internally.  See
> 'play-sound-internal' and 'play-sound'.  I guess it's mostly
> useful for very short sounds like beeps and alerts, where it's
> good to minimize the delay before the playing begins.

Wonderful.  :-)

Ludo’.