From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add cssc.
Date: Tue, 27 May 2014 23:13:38 +0200
Message-ID: <87sinuhqm5.fsf@gnu.org>
References: <1401219703-29822-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55134)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WpOgr-00074J-He
	for guix-devel@gnu.org; Tue, 27 May 2014 17:13:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WpOgm-000411-HD
	for guix-devel@gnu.org; Tue, 27 May 2014 17:13:45 -0400
In-Reply-To: <1401219703-29822-1-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Tue, 27 May 2014 21:41:43 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/version-control.scm (cssc): New variable.
> * gnu/packages/patches/cssc-gets-undeclared.patch: New file
> * gnu/packages/patches/cssc-missing-include.patch: New file

Please add the patches to gnu-system.am.  Also, make sure that each one
starts with one line describing what it does and whether it=E2=80=99s fixed
upstream.

> +                     ;; This test has no hope of passing until there is =
a "nogroup"
> +                     ;; entry (or at least some group to which the guix =
builder does
> +                     ;; not belong) in the /etc/group file of the build =
environment.
> +                     ;; Currently we do not have such a group.  This tes=
t is therefore
> +                     ;; destined to fail.
> +                     (substitute* "tests/Makefile"
> +                       (("test-delta ") ""))))

Please mark the comment as =E2=80=9CXXX:=E2=80=9D, and perhaps change the l=
ast sentence
to (say) =E2=80=9CThus, disable this test for now.=E2=80=9D

Thanks!

Ludo=E2=80=99.