From: ludo@gnu.org (Ludovic Courtès)
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add cssc.
Date: Tue, 27 May 2014 23:13:38 +0200 [thread overview]
Message-ID: <87sinuhqm5.fsf@gnu.org> (raw)
In-Reply-To: <1401219703-29822-1-git-send-email-jmd@gnu.org> (John Darrington's message of "Tue, 27 May 2014 21:41:43 +0200")
John Darrington <jmd@gnu.org> skribis:
> * gnu/packages/version-control.scm (cssc): New variable.
> * gnu/packages/patches/cssc-gets-undeclared.patch: New file
> * gnu/packages/patches/cssc-missing-include.patch: New file
Please add the patches to gnu-system.am. Also, make sure that each one
starts with one line describing what it does and whether it’s fixed
upstream.
> + ;; This test has no hope of passing until there is a "nogroup"
> + ;; entry (or at least some group to which the guix builder does
> + ;; not belong) in the /etc/group file of the build environment.
> + ;; Currently we do not have such a group. This test is therefore
> + ;; destined to fail.
> + (substitute* "tests/Makefile"
> + (("test-delta ") ""))))
Please mark the comment as “XXX:”, and perhaps change the last sentence
to (say) “Thus, disable this test for now.”
Thanks!
Ludo’.
next prev parent reply other threads:[~2014-05-27 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 19:41 [PATCH] gnu: Add cssc John Darrington
2014-05-27 21:13 ` Ludovic Courtès [this message]
2014-05-28 7:21 ` John Darrington
2014-05-28 9:59 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sinuhqm5.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).