[PATCH] gnu: Add ncmpcpp

[PATCH] gnu: Add ncmpcpp

[Cyrill Schenkel]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-ncmpcpp.patch --]
[-- Type: text/x-diff, Size: 1701 bytes --]

From 0c01e9239cc9b19e34323fe5bffb0e3bb2c40fed Mon Sep 17 00:00:00 2001
From: Cyrill Schenkel <cyrill.schenkel@gmail.com>
Date: Sat, 28 Jun 2014 16:36:49 +0200
Subject: [PATCH] gnu: Add ncmpcpp.

* gnu/packages/mpd.scm (ncmpcpp): New variable.
---
 gnu/packages/mpd.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 5841e8b..179a9a5 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -39,7 +39,8 @@
   #:use-module (gnu packages xiph)
   #:export (libmpdclient
             mpd
-            ncmpc))
+            ncmpc
+            ncmpcpp))
 
 (define libmpdclient
   (package
@@ -147,3 +148,25 @@ protocol.")
 terminal using ncurses.")
     (home-page "http://www.musicpd.org/clients/ncmpc/")
     (license license:gpl2)))
+
+(define ncmpcpp
+  (package
+    (name "ncmpcpp")
+    (version "0.5.10")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (string-append "http://ncmpcpp.rybczak.net/stable/ncmpcpp-"
+                              version ".tar.bz2"))
+              (sha256
+               (base32
+                "1a54g6dary1rirrny9fd0hpxpyyffypni3mpbdpvmjnrl9v56vgz"))))
+    (build-system gnu-build-system)
+    (inputs `(("libmpdclient" ,libmpdclient)
+              ("ncurses" ,ncurses)))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (synopsis "featureful ncurses based MPD client inspired by ncmpc")
+    (description "Ncmpcpp is very similar to ncmpc if it comes to user
+interface, but it provides a lot of new useful features. ")
+    (home-page "http://ncmpcpp.rybczak.net/")
+    (license license:gpl2)))
-- 
2.0.0

Re: [PATCH] gnu: Add ncmpcpp

[David Thompson]

Cyrill Schenkel <cyrill.schenkel@gmail.com> writes:

> From 0c01e9239cc9b19e34323fe5bffb0e3bb2c40fed Mon Sep 17 00:00:00 2001
> From: Cyrill Schenkel <cyrill.schenkel@gmail.com>
> Date: Sat, 28 Jun 2014 16:36:49 +0200
> Subject: [PATCH] gnu: Add ncmpcpp.
>
> * gnu/packages/mpd.scm (ncmpcpp): New variable.

Awesome!  This was on my "things to package" list.

> ---
>  gnu/packages/mpd.scm | 25 ++++++++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
> index 5841e8b..179a9a5 100644
> --- a/gnu/packages/mpd.scm
> +++ b/gnu/packages/mpd.scm
> @@ -39,7 +39,8 @@
>    #:use-module (gnu packages xiph)
>    #:export (libmpdclient
>              mpd
> -            ncmpc))
> +            ncmpc
> +            ncmpcpp))
>  
>  (define libmpdclient
>    (package
> @@ -147,3 +148,25 @@ protocol.")
>  terminal using ncurses.")
>      (home-page "http://www.musicpd.org/clients/ncmpc/")
>      (license license:gpl2)))
> +
> +(define ncmpcpp
> +  (package
> +    (name "ncmpcpp")
> +    (version "0.5.10")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (string-append "http://ncmpcpp.rybczak.net/stable/ncmpcpp-"
> +                              version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "1a54g6dary1rirrny9fd0hpxpyyffypni3mpbdpvmjnrl9v56vgz"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("libmpdclient" ,libmpdclient)
> +              ("ncurses" ,ncurses)))
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (synopsis "featureful ncurses based MPD client inspired by ncmpc")

Capitalize "featureful".

> +    (description "Ncmpcpp is very similar to ncmpc if it comes to user
> +interface, but it provides a lot of new useful features. ")

I think a slightly modified version of the description found on the Arch
Wiki would be more useful:

  Ncmpcpp is an mpd client with a UI very similar to ncmpc, but it
  provides new useful features such as support for regular expressions
  for library searches, extended song format, items filtering, the
  ability to sort playlists, and a local filesystem browser.

https://wiki.archlinux.org/index.php/Ncmpcpp

> +    (home-page "http://ncmpcpp.rybczak.net/")
> +    (license license:gpl2)))
> -- 
> 2.0.0
>
>

Looks good, otherwise.  Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] gnu: Add ncmpcpp

[Cyrill Schenkel]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hi David

> Capitalize "featureful".

Done.

> I think a slightly modified version of the description found on the Arch
> Wiki would be more useful:
>
>   Ncmpcpp is an mpd client with a UI very similar to ncmpc, but it
>   provides new useful features such as support for regular expressions
>   for library searches, extended song format, items filtering, the
>   ability to sort playlists, and a local filesystem browser.

I agree. Changed it in the attached patch.

Regards
Cyrill


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-ncmpcpp.patch --]
[-- Type: text/x-diff, Size: 1853 bytes --]

From 75afd07580a130a50a067511114c7e32417624f5 Mon Sep 17 00:00:00 2001
From: Cyrill Schenkel <cyrill.schenkel@gmail.com>
Date: Sun, 29 Jun 2014 10:23:28 +0200
Subject: [PATCH] gnu: Add ncmpcpp.

* gnu/packages/mpd.scm (ncmpcpp): New variable.
---
 gnu/packages/mpd.scm | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 5841e8b..5d603a1 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -39,7 +39,8 @@
   #:use-module (gnu packages xiph)
   #:export (libmpdclient
             mpd
-            ncmpc))
+            ncmpc
+            ncmpcpp))
 
 (define libmpdclient
   (package
@@ -147,3 +148,27 @@ protocol.")
 terminal using ncurses.")
     (home-page "http://www.musicpd.org/clients/ncmpc/")
     (license license:gpl2)))
+
+(define ncmpcpp
+  (package
+    (name "ncmpcpp")
+    (version "0.5.10")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (string-append "http://ncmpcpp.rybczak.net/stable/ncmpcpp-"
+                              version ".tar.bz2"))
+              (sha256
+               (base32
+                "1a54g6dary1rirrny9fd0hpxpyyffypni3mpbdpvmjnrl9v56vgz"))))
+    (build-system gnu-build-system)
+    (inputs `(("libmpdclient" ,libmpdclient)
+              ("ncurses" ,ncurses)))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (synopsis "Featureful ncurses based MPD client inspired by ncmpc")
+    (description "Ncmpcpp is an mpd client with a UI very similar to ncmpc,
+but it provides new useful features such as support for regular expressions
+for library searches, extended song format, items filtering, the ability to
+sort playlists, and a local filesystem browser.")
+    (home-page "http://ncmpcpp.rybczak.net/")
+    (license license:gpl2)))
-- 
2.0.0

Re: [PATCH] gnu: Add ncmpcpp

[Ludovic Courtès]

Hello,

Cyrill Schenkel <cyrill.schenkel@gmail.com> skribis:

> I agree. Changed it in the attached patch.

Applied.  Thanks, and welcome aboard.  ;-)

> +    (license license:gpl2)))

I changed it to ‘license:gpl2+’, because all the source files carry the
“or later” clause.

Under the assumption that you’re the copyright holder, I’ve added this
line to mpd.scm:

;;; Copyright © 2014 Cyrill Schenkel <cyrill.schenkel@gmail.com>

Please let me know if this is incorrect.

Ludo’.