From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
Date: Mon, 03 Nov 2014 23:11:42 +0100
Message-ID: <87sii07x41.fsf@gnu.org>
References: <CAKrPhPNzm7YRPjA98hO=ozc+3ynkb0-4Nb4zvY+hd_EiTWwADA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44072)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XlPqQ-0004hl-5h
	for guix-devel@gnu.org; Mon, 03 Nov 2014 17:11:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XlPqL-000182-Cj
	for guix-devel@gnu.org; Mon, 03 Nov 2014 17:11:26 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:45865)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XlPqL-00017w-69
	for guix-devel@gnu.org; Mon, 03 Nov 2014 17:11:21 -0500
In-Reply-To: <CAKrPhPNzm7YRPjA98hO=ozc+3ynkb0-4Nb4zvY+hd_EiTWwADA@mail.gmail.com>
	(Federico Beffa's message of "Sun, 2 Nov 2014 18:21:17 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>

Federico Beffa <beffa@ieee.org> skribis:

> From 7439f19c1f2966466da88554478b796c3bfca429 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Sun, 2 Nov 2014 18:09:33 +0100
> Subject: [PATCH 2/2] gnu: Add gnome-themes-standard.
>
> * gnu/packages/gnome.scm (gnome-themes-standard): New variable.

[...]

> +;; The version of this package should be the same as the version of
> +;; gnome-desktop.
> +(define-public gnome-themes-standard
> +  (package
> +    (name "gnome-themes-standard")
> +    (version "3.10.0")

Please use (version (package-version gnome-desktop)) here, and put the
comment just above it.

> +       (uri (string-append "mirror://gnome/sources/" name "/"=20
> +                           (string-take version 4) "/" name "-"

Use =E2=80=98version-major+minor=E2=80=99 instead of =E2=80=98string-take=
=E2=80=99.

OK to push with these changes.

Thanks!

Ludo=E2=80=99.