From: ludo@gnu.org (Ludovic Courtès)
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
Date: Tue, 04 Nov 2014 17:52:27 +0100 [thread overview]
Message-ID: <87sihyzz5g.fsf@gnu.org> (raw)
In-Reply-To: <CAKrPhPMi1rrQ7r0PzZHkmkq5vXdtGs953O8Ke6SjXd67iV+0vw@mail.gmail.com> (Federico Beffa's message of "Tue, 4 Nov 2014 12:15:15 +0100")
Federico Beffa <beffa@ieee.org> skribis:
> On Mon, Nov 3, 2014 at 11:11 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>>> +;; The version of this package should be the same as the version of
>>> +;; gnome-desktop.
>>> +(define-public gnome-themes-standard
>>> + (package
>>> + (name "gnome-themes-standard")
>>> + (version "3.10.0")
>>
>> Please use (version (package-version gnome-desktop)) here, and put the
>> comment just above it.
>
> I thought about this, but did not do it because, if the version
> changes, then you also need to change the hash. So, if someone
> changes gnome-desktop without bothering about gnome-themes-standard,
> then the latter would break.
I think using (package-version gnome-desktop) would make the intent
clear, and the breakage that would occur would give a heads-up and an
incentive to fix it.
How does that sound?
Ludo’.
next prev parent reply other threads:[~2014-11-04 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 17:21 [PATCH 2/2] gnu: Add gnome-themes-standard Federico Beffa
2014-11-03 22:11 ` Ludovic Courtès
2014-11-04 11:15 ` Federico Beffa
2014-11-04 16:52 ` Ludovic Courtès [this message]
2014-11-04 17:21 ` Federico Beffa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sihyzz5g.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=beffa@ieee.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).