unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Acl
@ 2014-11-05 19:35 Andreas Enge
  2014-11-05 20:38 ` Acl Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Andreas Enge @ 2014-11-05 19:35 UTC (permalink / raw)
  To: guix-devel

Adding optional inputs to kdelibs, I notice that acl is not recognised.
The reason is that the header files are not installed. Would that be easy
to modify? Maybe by changing the line
  (zero? (system* "make" "install" "install-lib")))
to
  (zero? (system* "make" "install")))
or not replacing the normal install phase (but then there may be a
reason for this special command!).

Concerning the acl test failures, I tried
 #:tests? #t
and found that there is no "check" target. A good reason for the
tests to fail...

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Acl
  2014-11-05 19:35 Acl Andreas Enge
@ 2014-11-05 20:38 ` Ludovic Courtès
  2014-11-06 21:38   ` Acl Andreas Enge
  2014-11-08  7:39   ` Acl Mark H Weaver
  0 siblings, 2 replies; 7+ messages in thread
From: Ludovic Courtès @ 2014-11-05 20:38 UTC (permalink / raw)
  To: Andreas Enge; +Cc: guix-devel

Andreas Enge <andreas@enge.fr> skribis:

> Adding optional inputs to kdelibs, I notice that acl is not recognised.
> The reason is that the header files are not installed. Would that be easy
> to modify? Maybe by changing the line
>   (zero? (system* "make" "install" "install-lib")))

Commit 16755848 added ‘install-lib’ (before that libacl.so was not
installed), but yeah, installing headers would have been cool too.  ;-)

> to
>   (zero? (system* "make" "install")))
> or not replacing the normal install phase (but then there may be a
> reason for this special command!).

ISTR that the ‘install’ target installs only the executables.

> Concerning the acl test failures, I tried
>  #:tests? #t
> and found that there is no "check" target. A good reason for the
> tests to fail...

Heh.

Anyway, this is depended on by Coreutils, so changes should go to
core-updates.

In the meantime, you can always add a fixed version of ACL for use in
KDE (you could even add a ‘replacement’ field pointing to it in ‘acl’
itself, although that doesn’t seem like a very good use case.)

Thanks for looking into it!

Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Acl
  2014-11-05 20:38 ` Acl Ludovic Courtès
@ 2014-11-06 21:38   ` Andreas Enge
  2014-11-06 22:09     ` Acl Andreas Enge
  2014-11-08  7:39   ` Acl Mark H Weaver
  1 sibling, 1 reply; 7+ messages in thread
From: Andreas Enge @ 2014-11-06 21:38 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Wed, Nov 05, 2014 at 09:38:32PM +0100, Ludovic Courtès wrote:
> Commit 16755848 added ‘install-lib’ (before that libacl.so was not
> installed)

Ah, nothing stops the progress!

Just to make sure that I understand things correctly: Can we drop the
'patch-makefile-SHELL phase? There is no occurrence of the string "SHELL"
in include/buildmacros for the current version.

> Anyway, this is depended on by Coreutils, so changes should go to
> core-updates.

Okay. Should we open the branch?

> In the meantime, you can always add a fixed version of ACL for use in
> KDE (you could even add a ‘replacement’ field pointing to it in ‘acl’
> itself, although that doesn’t seem like a very good use case.)

Well, acl is optional, so there is no hurry.

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Acl
  2014-11-06 21:38   ` Acl Andreas Enge
@ 2014-11-06 22:09     ` Andreas Enge
  2014-11-07  9:15       ` Acl Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Andreas Enge @ 2014-11-06 22:09 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 48 bytes --]

The attached patch should do the job.

Andreas


[-- Attachment #2: 0001-gnu-acl-Also-install-header-files.patch --]
[-- Type: text/plain, Size: 1437 bytes --]

From 34f1cd18d14a0a75d73e7f4b57f76495edae56d8 Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Thu, 6 Nov 2014 22:56:32 +0100
Subject: [PATCH] gnu: acl: Also install header files.

* gnu/packages/acl.scm (acl): Install header files. Drop unneeded phase
    PATCH-MAKEFILE-SHELL.
---
 gnu/packages/acl.scm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm
index cbe14c9..ee101da 100644
--- a/gnu/packages/acl.scm
+++ b/gnu/packages/acl.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2012 Nikita Karetnikov <nikita@karetnikov.org>
 ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2014 Andreas Enge <andreas@enge.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -42,15 +43,11 @@
     (arguments
      `(#:tests? #f   ; FIXME: Investigate test suite failures
        #:phases
-       (alist-cons-after
-        'configure 'patch-makefile-SHELL
-        (lambda _
-          (patch-makefile-SHELL "include/buildmacros"))
         (alist-replace
          'install
          (lambda _
-           (zero? (system* "make" "install" "install-lib")))
-         %standard-phases))))
+           (zero? (system* "make" "install" "install-lib" "install-dev")))
+         %standard-phases)))
     (inputs `(("attr" ,attr)))
     (native-inputs
      `(("gettext" ,gnu-gettext)))
-- 
2.1.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: Acl
  2014-11-06 22:09     ` Acl Andreas Enge
@ 2014-11-07  9:15       ` Ludovic Courtès
  2014-11-07 22:30         ` Acl Andreas Enge
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2014-11-07  9:15 UTC (permalink / raw)
  To: Andreas Enge; +Cc: guix-devel

Andreas Enge <andreas@enge.fr> skribis:

> From 34f1cd18d14a0a75d73e7f4b57f76495edae56d8 Mon Sep 17 00:00:00 2001
> From: Andreas Enge <andreas@enge.fr>
> Date: Thu, 6 Nov 2014 22:56:32 +0100
> Subject: [PATCH] gnu: acl: Also install header files.
>
> * gnu/packages/acl.scm (acl): Install header files. Drop unneeded phase
>     PATCH-MAKEFILE-SHELL.

OK.  Could you create the ‘core-updates’ branch and commit it?

Thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Acl
  2014-11-07  9:15       ` Acl Ludovic Courtès
@ 2014-11-07 22:30         ` Andreas Enge
  0 siblings, 0 replies; 7+ messages in thread
From: Andreas Enge @ 2014-11-07 22:30 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Fri, Nov 07, 2014 at 10:15:12AM +0100, Ludovic Courtès wrote:
> OK.  Could you create the ‘core-updates’ branch and commit it?

Done. I have also worked a bit on tests and got them to execute at least.

Now a few of the first ones fail like this:
[16] $ ls -dl d | awk '{print $1}' | sed 's/.$//g' -- failed
drwxr-xr-                             != drwxr-xr-t
[18] $ ls -dl d/u | awk '{print $1}' | sed 's/.$//g' -- failed
-rwSr--r-                             != -rwSr--r--
[20] $ ls -dl d/g | awk '{print $1}' | sed 's/.$//g' -- failed
-rw-r-Sr-                             != -rw-r-Sr--

It looks as if "ls -dl" were expected to output one character more than
it does. The tests also fail outside of guix. When I drop the "sed ...",
these tests pass, but then others fail.

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Acl
  2014-11-05 20:38 ` Acl Ludovic Courtès
  2014-11-06 21:38   ` Acl Andreas Enge
@ 2014-11-08  7:39   ` Mark H Weaver
  1 sibling, 0 replies; 7+ messages in thread
From: Mark H Weaver @ 2014-11-08  7:39 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

ludo@gnu.org (Ludovic Courtès) writes:

> ndreas Enge <andreas@enge.fr> skribis:
>
>> Adding optional inputs to kdelibs, I notice that acl is not recognised.
>> The reason is that the header files are not installed. Would that be easy
>> to modify? Maybe by changing the line
>>   (zero? (system* "make" "install" "install-lib")))
>
> Commit 16755848 added ‘install-lib’ (before that libacl.so was not
> installed), but yeah, installing headers would have been cool too.  ;-)

Indeed.  I would apologize for overlooking this, but doc/INSTALL
specifically recommends "make install install-lib", and "install-dev"
appears to be completely undocumented :-/

      Mark

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-11-08  7:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-05 19:35 Acl Andreas Enge
2014-11-05 20:38 ` Acl Ludovic Courtès
2014-11-06 21:38   ` Acl Andreas Enge
2014-11-06 22:09     ` Acl Andreas Enge
2014-11-07  9:15       ` Acl Ludovic Courtès
2014-11-07 22:30         ` Acl Andreas Enge
2014-11-08  7:39   ` Acl Mark H Weaver

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).