From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] services: lsh: Add "graceful" handling of daemonic option.
Date: Sun, 08 Feb 2015 21:56:11 +0100
Message-ID: <87siegnmvo.fsf@gnu.org>
References: <CAJ41eewmqwPhQXZRJXdJuHGA=sSRJG7dK86sWfCgusb+AXBNxg@mail.gmail.com>
	<CAJ41eewv6GMBtoaTCiHmifiOMKsy6UkVripMxDjQAAFnh2qJgg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49388)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YKYtu-0007FJ-Nw
	for guix-devel@gnu.org; Sun, 08 Feb 2015 15:56:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YKYtq-000112-1P
	for guix-devel@gnu.org; Sun, 08 Feb 2015 15:56:18 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38316)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YKYtp-00010u-VF
	for guix-devel@gnu.org; Sun, 08 Feb 2015 15:56:13 -0500
In-Reply-To: <CAJ41eewv6GMBtoaTCiHmifiOMKsy6UkVripMxDjQAAFnh2qJgg@mail.gmail.com>
	(Deck Pickard's message of "Thu, 4 Dec 2014 23:24:02 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Deck Pickard <deck.r.pickard@gmail.com>
Cc: guix-devel@gnu.org

Hi!

Deck Pickard <deck.r.pickard@gmail.com> skribis:

> From 1fef935d6292016c04b9234eedb5dcaf006dc152 Mon Sep 17 00:00:00 2001
> From: nebuli <nebu@kipple>
> Date: Wed, 3 Dec 2014 22:51:48 +0100
> Subject: [PATCH] services: lsh: Add graceful handling of daemonic option.
>
> * doc/guix.texi: Mention use case.
> * gnu/services/ssh.scm (lsh-service): New #:keys (daemonic?, pid-file?,
>   pid-file).  Build new lshd-command and expand service-requirement
>   field.

This patch had fallen through the cracks, sorry about that.

I=E2=80=99ve applied it with minor changes: I changed #:daemonic? to defaul=
t to
#t, I added #:pid-file? to the documentation, and simplified the syntax
for the =E2=80=98requirements=E2=80=99 field as discussed.

I ended up leaving all the options, as you intended, so that users can
choose whether or not to use daemonic mode.

Thank you!

Ludo=E2=80=99.