* [PATCH]: gnu: Add lash.
@ 2015-02-13 22:21 Ricardo Wurmus
2015-02-13 23:01 ` David Thompson
0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2015-02-13 22:21 UTC (permalink / raw)
To: Guix-devel
[-- Attachment #1: Type: text/plain, Size: 84 bytes --]
Attached is a patch to add lash, an audio application session handler.
~~ Ricardo
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-lash.patch --]
[-- Type: text/x-patch, Size: 2056 bytes --]
From 19edc131b719981a9545867bf167daa642551a08 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Fri, 13 Feb 2015 23:20:00 +0100
Subject: [PATCH] gnu: Add lash.
* gnu/packages/audio.scm (lash): New variable.
---
gnu/packages/audio.scm | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 81e07c2..d0e1842 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -256,6 +256,43 @@ synchronous execution of all clients, and low latency operation.")
to be plugged into a wide range of audio synthesis and recording packages.")
(license license:lgpl2.1+)))
+(define-public lash
+ (package
+ (name "lash")
+ (version "0.6.0-rc2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "mirror://savannah/lash/lash-"
+ (string-map (lambda (x) (if (char=? x #\-) #\~ x)) version)
+ ".tar.bz2"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "12z1vx3krrzsfccpah9xjs68900xvr7bw92wx8np5871i2yv47iw"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("bdb" ,bdb)
+ ("gtk" ,gtk+-2)
+ ("jack" ,jack-1)
+ ("libuuid" ,util-linux)
+ ("readline" ,readline)
+ ("python" ,python-2)))
+ (propagated-inputs
+ `(("alsa-lib" ,alsa-lib)
+ ("dbus" ,dbus)
+ ("libxml2" ,libxml2)))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (home-page "http://www.nongnu.org/lash/")
+ (synopsis "Audio application session manager")
+ (description
+ "LASH is a session management system for audio applications. It allows
+you to save and restore audio sessions consisting of multiple interconneced
+applications, restoring program state (i.e. loaded patches) and the
+connections between them.")
+ (license license:gpl2+)))
+
(define-public liblo
(package
(name "liblo")
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH]: gnu: Add lash.
2015-02-13 22:21 [PATCH]: gnu: Add lash Ricardo Wurmus
@ 2015-02-13 23:01 ` David Thompson
2015-02-13 23:14 ` Ricardo Wurmus
0 siblings, 1 reply; 4+ messages in thread
From: David Thompson @ 2015-02-13 23:01 UTC (permalink / raw)
To: Ricardo Wurmus, Guix-devel
Ricardo Wurmus <rekado@elephly.net> writes:
> Attached is a patch to add lash, an audio application session handler.
>
> ~~ Ricardo
>
> From 19edc131b719981a9545867bf167daa642551a08 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Fri, 13 Feb 2015 23:20:00 +0100
> Subject: [PATCH] gnu: Add lash.
>
> * gnu/packages/audio.scm (lash): New variable.
> ---
> gnu/packages/audio.scm | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 81e07c2..d0e1842 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -256,6 +256,43 @@ synchronous execution of all clients, and low latency operation.")
> to be plugged into a wide range of audio synthesis and recording packages.")
> (license license:lgpl2.1+)))
>
> +(define-public lash
> + (package
> + (name "lash")
> + (version "0.6.0-rc2")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://savannah/lash/lash-"
> + (string-map (lambda (x) (if (char=? x #\-) #\~ x)) version)
How about splitting the string on #\- and then joining on #\~ instead?
> + ".tar.bz2"))
> + (file-name (string-append name "-" version ".tar.gz"))
The extension should be ".tar.bz2".
> + (sha256
> + (base32
> + "12z1vx3krrzsfccpah9xjs68900xvr7bw92wx8np5871i2yv47iw"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("bdb" ,bdb)
> + ("gtk" ,gtk+-2)
> + ("jack" ,jack-1)
> + ("libuuid" ,util-linux)
> + ("readline" ,readline)
> + ("python" ,python-2)))
> + (propagated-inputs
> + `(("alsa-lib" ,alsa-lib)
> + ("dbus" ,dbus)
> + ("libxml2" ,libxml2)))
I'm always wary of propagated inputs, but I'll take your word for it. :)
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (home-page "http://www.nongnu.org/lash/")
> + (synopsis "Audio application session manager")
> + (description
> + "LASH is a session management system for audio applications. It allows
> +you to save and restore audio sessions consisting of multiple interconneced
> +applications, restoring program state (i.e. loaded patches) and the
> +connections between them.")
> + (license license:gpl2+)))
> +
> (define-public liblo
> (package
> (name "liblo")
> --
> 2.1.0
>
Could you send an updated patch? Thanks!
--
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH]: gnu: Add lash.
2015-02-13 23:01 ` David Thompson
@ 2015-02-13 23:14 ` Ricardo Wurmus
2015-02-14 5:38 ` Mark H Weaver
0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2015-02-13 23:14 UTC (permalink / raw)
To: David Thompson; +Cc: Guix-devel
David Thompson writes:
>> + (uri (string-append
>> + "mirror://savannah/lash/lash-"
>> + (string-map (lambda (x) (if (char=? x #\-) #\~ x)) version)
>
> How about splitting the string on #\- and then joining on #\~ instead?
Yeah, that would probably look better. (I just adapted this from
another package without thinking much of it.)
>> + ".tar.bz2"))
>> + (file-name (string-append name "-" version ".tar.gz"))
>
> The extension should be ".tar.bz2".
Ouch! Good catch!
>> + (sha256
>> + (base32
>> + "12z1vx3krrzsfccpah9xjs68900xvr7bw92wx8np5871i2yv47iw"))))
>> + (build-system gnu-build-system)
>> + (inputs
>> + `(("bdb" ,bdb)
>> + ("gtk" ,gtk+-2)
>> + ("jack" ,jack-1)
>> + ("libuuid" ,util-linux)
>> + ("readline" ,readline)
>> + ("python" ,python-2)))
>> + (propagated-inputs
>> + `(("alsa-lib" ,alsa-lib)
>> + ("dbus" ,dbus)
>> + ("libxml2" ,libxml2)))
>
> I'm always wary of propagated inputs, but I'll take your word for it. :)
I'm not sure I'm doing this right, but I noticed that in a package using
lash pkg-config complained about not being able to confirm a working
lash because of these three missing dependencies. These are lash
dependencies that are listed in PC_REQUIRES. As far as I can tell any
package dependent on lash would have to have at least these three
packages as inputs. The complete list of PC_REQUIRES is this:
dbus, libuuid, libxml2, alsa, jack
I would be happy if someone could confirm that this is how propagated
inputs are to be used, and if lash should propagate all five of these
inputs (instead of only the three here).
~~ Ricardo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH]: gnu: Add lash.
2015-02-13 23:14 ` Ricardo Wurmus
@ 2015-02-14 5:38 ` Mark H Weaver
0 siblings, 0 replies; 4+ messages in thread
From: Mark H Weaver @ 2015-02-14 5:38 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: Guix-devel
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
> David Thompson writes:
>
>>> + (uri (string-append
>>> + "mirror://savannah/lash/lash-"
>>> + (string-map (lambda (x) (if (char=? x #\-) #\~ x)) version)
>>
>> How about splitting the string on #\- and then joining on #\~ instead?
>
> Yeah, that would probably look better. (I just adapted this from
> another package without thinking much of it.)
Either way is fine with me.
Also, could you please add a comment explaining why we are doing this
instead of just putting '~' in the 'version' field?
>>> + ".tar.bz2"))
>>> + (file-name (string-append name "-" version ".tar.gz"))
>>
>> The extension should be ".tar.bz2".
>
> Ouch! Good catch!
Indeed, thanks David!
>>> + (sha256
>>> + (base32
>>> + "12z1vx3krrzsfccpah9xjs68900xvr7bw92wx8np5871i2yv47iw"))))
>>> + (build-system gnu-build-system)
>>> + (inputs
>>> + `(("bdb" ,bdb)
>>> + ("gtk" ,gtk+-2)
>>> + ("jack" ,jack-1)
>>> + ("libuuid" ,util-linux)
>>> + ("readline" ,readline)
>>> + ("python" ,python-2)))
>>> + (propagated-inputs
>>> + `(("alsa-lib" ,alsa-lib)
>>> + ("dbus" ,dbus)
>>> + ("libxml2" ,libxml2)))
>>
>> I'm always wary of propagated inputs, but I'll take your word for it. :)
>
> I'm not sure I'm doing this right, but I noticed that in a package using
> lash pkg-config complained about not being able to confirm a working
> lash because of these three missing dependencies. These are lash
> dependencies that are listed in PC_REQUIRES. As far as I can tell any
> package dependent on lash would have to have at least these three
> packages as inputs.
Yes, I think this justifies adding them to 'propagated-inputs'. Could
you add a comment?
> The complete list of PC_REQUIRES is this:
>
> dbus, libuuid, libxml2, alsa, jack
>
> I would be happy if someone could confirm that this is how propagated
> inputs are to be used, and if lash should propagate all five of these
> inputs (instead of only the three here).
I'm not sure. For now, I'd suggest just adding the three here, and we
can revisit later if we run into problems or if someone does a more
careful study.
Okay to push with these changes.
Thanks!
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-14 5:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-13 22:21 [PATCH]: gnu: Add lash Ricardo Wurmus
2015-02-13 23:01 ` David Thompson
2015-02-13 23:14 ` Ricardo Wurmus
2015-02-14 5:38 ` Mark H Weaver
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).