From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add python-pyxdg.
Date: Tue, 14 Apr 2015 11:52:18 +0200
Message-ID: <87sic3ghpp.fsf@gnu.org>
References: <871tjn42qk.fsf@mango.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58232)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YhxW5-0003UO-Ml
	for guix-devel@gnu.org; Tue, 14 Apr 2015 05:52:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YhxW1-00046l-17
	for guix-devel@gnu.org; Tue, 14 Apr 2015 05:52:25 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41120)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YhxW0-00046f-Ts
	for guix-devel@gnu.org; Tue, 14 Apr 2015 05:52:20 -0400
In-Reply-To: <871tjn42qk.fsf@mango.localdomain> (Ricardo Wurmus's message of
	"Tue, 14 Apr 2015 08:56:35 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <rekado@elephly.net> skribis:

> One of the tests is failing.  I do not know why a PNG image is detected
> as 'x-apple-ios-png' rather than the expected 'png', but I suspect it's
> a problem in "shared-mime-info".

Weird.  Normally setting XDG_DATA_DIRS as you did is all it takes, AIUI.

> I made the check phase return #t to
> avoid a build failure.

It would be even better to somehow adjust the test files to skip this
one, but if that=E2=80=99s too much burden, I=E2=80=99m fine with this appr=
oach.

> From e9ba9a6bee8ff6d503e1c3f87b407e872afda193 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Tue, 14 Apr 2015 08:53:03 +0200
> Subject: [PATCH] gnu: Add python-pyxdg.
>
> * gnu/packages/freedesktop.scm (python-pyxdg, python2-pyxdg): New variabl=
es.

[...]

> +    (home-page "http://freedesktop.org/wiki/Software/pyxdg")
> +    (synopsis "Implementations of freedesktop.org standards in Python")
> +    (description
> +     "PyXDG is a collection of implementations of freedesktop.org standa=
rds in
> +Python")

Missing period.  Also, I would make it:

  ... standards in Python: Base Directory, Menu, Desktop Entry, Icon
  Theme, Recent File, and Shared-MIME-Database.

> +    (license lgpl2.0)))

v2.0-only?

Otherwise LGTM.

Thank you!

Ludo=E2=80=99.