From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Mickey <j@codemac.net>
Subject: Re: [PATCH] gnu: add the rc shell package
Date: Fri, 10 Jul 2015 15:27:54 -0700
Message-ID: <87si8vbqc5.fsf@codemac.net>
References: <871tggddtr.fsf@codemac.net>
	<idjy4io2jwd.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50950)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <j@codemac.net>) id 1ZDgm5-0001Uq-Rn
	for guix-devel@gnu.org; Fri, 10 Jul 2015 18:28:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <j@codemac.net>) id 1ZDgm1-0003S8-0h
	for guix-devel@gnu.org; Fri, 10 Jul 2015 18:28:05 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35604)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <j@codemac.net>) id 1ZDgm0-0003S0-Po
	for guix-devel@gnu.org; Fri, 10 Jul 2015 18:28:00 -0400
In-Reply-To: <idjy4io2jwd.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org

* Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> [2015-07-10 06:59]:
> Please add a comment to explain why the tests are disabled (no =E2=80=9Cc=
heck=E2=80=9D
> target or failing tests?).

The tests are written in an m4 file which generates a configure script
that generates c main()'s that are compiled and run as tests against
rc.. there was a /bin/pwd in there that failed the test and I didn't
think a simple sed would be able to remove that part of the test.

I will include an explanation in my followup.

> The alignment and length of the lines makes it hard to read.  How
> about this instead:
[...]

Yea - I think emacs must not be loading the right scheme settings from
.dir-locals.el for some reason, any pointers to a "blessed config" or
style guide would be awesome.

Thanks for the review - the comments were very helpful and I'll be
updating the package shortly!

  //  codemac