From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] scripts: package: Add --install-from-file option.
Date: Tue, 18 Aug 2015 21:30:26 +0200
Message-ID: <87si7ggzsd.fsf@gnu.org>
References: <8737zs78rs.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46211)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZRmae-0007dz-DM
	for guix-devel@gnu.org; Tue, 18 Aug 2015 15:30:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZRmaa-0007tp-Tb
	for guix-devel@gnu.org; Tue, 18 Aug 2015 15:30:32 -0400
In-Reply-To: <8737zs78rs.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	(David Thompson's message of "Sun, 09 Aug 2015 11:59:19 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> In my personal projects, I keep a 'package.scm' file in the root of the
> source tree for use with 'guix environment -l'.  However, it's also
> handy to install that package by using 'guix package -e':
>
>     guix package -e '(primitive-load "package.scm")'
>
> This patch adds a shorthand for this:
>
>     guix package -f package.scm

Makes sense.

> The motivation for this is to ultimately encourage other people to keep
> a 'package.scm' file in their own repos for building reproducible
> development environments and easily testing development snapshots, like
> what we do with our 'guix-devel' package.

Nice.  The bottom line though is that we don=E2=80=99t quite guarantee stab=
ility
of the =E2=80=9CAPI=E2=80=9D of the package modules.

> I'd like to add the same option for 'guix build', if this is approved.

Sure.

> From 07c9b35facf810872f3bc8342e18b33033714adf Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Sun, 9 Aug 2015 11:35:51 -0400
> Subject: [PATCH] scripts: package: Add --install-from-file option.
>
> * guix/scripts/package.scm (show-help): Add help text for --install-from-=
file
>   option.
>   (%options): Add --install-from-file option.
> * doc/guix.texi ("invoking guix package"): Document it.

[...]

> +(use-modules (guix packages)
> +             (guix download)
> +             (guix build-system gnu)
> +             (guix licenses))

Just (use-modules (guix) (guix licenses))?

Can you put the example in a separate file (like
doc/environment-gdb.scm)?  That will allow us to easily check that the
file is indeed valid.

> +  (arguments `(#:configure-flags '("--enable-silent-rules")))
> +  (inputs `(("gawk" ,gawk)))

I think these two lines can be removed.

> +@end example

Here it would be good to add a sentence or two like the paragraph you
wrote above about the motivation for all this.

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.