unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] scripts: package: Add --install-from-file option.
Date: Tue, 18 Aug 2015 21:30:26 +0200	[thread overview]
Message-ID: <87si7ggzsd.fsf@gnu.org> (raw)
In-Reply-To: <8737zs78rs.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Sun, 09 Aug 2015 11:59:19 -0400")

David Thompson <dthompson2@worcester.edu> skribis:

> In my personal projects, I keep a 'package.scm' file in the root of the
> source tree for use with 'guix environment -l'.  However, it's also
> handy to install that package by using 'guix package -e':
>
>     guix package -e '(primitive-load "package.scm")'
>
> This patch adds a shorthand for this:
>
>     guix package -f package.scm

Makes sense.

> The motivation for this is to ultimately encourage other people to keep
> a 'package.scm' file in their own repos for building reproducible
> development environments and easily testing development snapshots, like
> what we do with our 'guix-devel' package.

Nice.  The bottom line though is that we don’t quite guarantee stability
of the “API” of the package modules.

> I'd like to add the same option for 'guix build', if this is approved.

Sure.

> From 07c9b35facf810872f3bc8342e18b33033714adf Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Sun, 9 Aug 2015 11:35:51 -0400
> Subject: [PATCH] scripts: package: Add --install-from-file option.
>
> * guix/scripts/package.scm (show-help): Add help text for --install-from-file
>   option.
>   (%options): Add --install-from-file option.
> * doc/guix.texi ("invoking guix package"): Document it.

[...]

> +(use-modules (guix packages)
> +             (guix download)
> +             (guix build-system gnu)
> +             (guix licenses))

Just (use-modules (guix) (guix licenses))?

Can you put the example in a separate file (like
doc/environment-gdb.scm)?  That will allow us to easily check that the
file is indeed valid.

> +  (arguments `(#:configure-flags '("--enable-silent-rules")))
> +  (inputs `(("gawk" ,gawk)))

I think these two lines can be removed.

> +@end example

Here it would be good to add a sentence or two like the paragraph you
wrote above about the motivation for all this.

Could you send an updated patch?

Thanks!

Ludo’.

  parent reply	other threads:[~2015-08-18 19:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-09 15:59 [PATCH] scripts: package: Add --install-from-file option David Thompson
2015-08-10 14:22 ` Alex Kost
2015-08-18 19:30 ` Ludovic Courtès [this message]
2015-08-19  0:17   ` Thompson, David
2015-08-19 22:38     ` Ludovic Courtès
2015-08-20  2:26       ` Thompson, David
2015-08-19  8:27 ` Amirouche Boubekki
2015-08-19  8:56   ` Amirouche Boubekki
2015-08-19 14:48     ` Claes Wallin (韋嘉誠)
2015-08-19 13:04   ` Thompson, David
2015-08-19 13:54     ` Taylan Ulrich Bayırlı/Kammer
2015-08-19 15:31     ` Amirouche Boubekki
2015-08-19 19:15       ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si7ggzsd.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).