From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 12/13] gnu: Add xmonad.
Date: Mon, 31 Aug 2015 17:52:36 +0200
Message-ID: <87si6z5ubf.fsf@gnu.org>
References: <1439930415-16938-1-git-send-email-sinisa@bidin.eu>
	<1439930415-16938-13-git-send-email-sinisa@bidin.eu>
	<20150823154729.4dd46618@openmailbox.org>
	<5edb43e2e6528f1b73be2dc115907b68@bidin.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZWRO0-0001t3-EH
	for guix-devel@gnu.org; Mon, 31 Aug 2015 11:52:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZWRNv-00058d-BA
	for guix-devel@gnu.org; Mon, 31 Aug 2015 11:52:44 -0400
In-Reply-To: <5edb43e2e6528f1b73be2dc115907b68@bidin.eu> (=?utf-8?Q?=22Sin?=
	=?utf-8?Q?i=C5=A1a_Bi=C4=91in=22's?=
	message of "Mon, 24 Aug 2015 05:00:03 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?U2luacWhYSBCacSRaW4=?= <sinisa@bidin.eu>
Cc: guix-devel@gnu.org

Sini=C5=A1a Bi=C4=91in <sinisa@bidin.eu> skribis:

> On 2015-08-23 22:47, Eric Bavier wrote:
>> I had to replace "Exec=3D/etc/X11/Session/xmonad" with "Exec=3Dxmonad"
>> in this xmonad.desktop file in order to launch an xmonad session from
>> Slim.  Does this seem right?
>
> Definitely!

[...]

>> Does it make sense to fetch this file
>> from gentoo.org and then modify it? or should we rather just
>> generate it
>> ourselves?  What do you/others think?
>
> I had followed ratpoison's example (also using gentoo.org), but it does
> feel dirty. I'm fine with generating it or having it stored in guix's
> repo,
> but couldn't find an example of any other package doing the same.

I think =E2=80=9Cgenerating=E2=80=9D it (or having it as a string literal) =
in the source
is preferable.

>>> +    (propagated-inputs
>>> +     `(("ghc-mtl" ,ghc-mtl)
>>> +       ("ghc-utf8-string" ,ghc-utf8-string)
>>> +       ("ghc-extensible-exceptions" ,ghc-extensible-exceptions)
>>> +       ("ghc-x11" ,ghc-x11)))
>>
>> Do these inputs need to be propagated?  I can start up an xmonad
>> session without propagating these inputs.  Do they need to be available
>> for xmonad's 'mod-q' (i.e. restarting xmonad/loading a new config)?
>
> I think so, yes. For one, since xmonad is an executable and a library,
> if
> we don't propagate, "ghc-pkg list" will report it as broken.

Makes sense to me.

Could you post an updated patch that addresses these two things?

TIA, and sorry for the delay!

Ludo=E2=80=99.