From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH] gnu: Add xcompmgr
Date: Fri, 23 Oct 2015 11:46:10 +0200
Message-ID: <87si51or31.fsf@denknerd.org>
References: <87si517rav.fsf@SIRIUSGUIX00.i-did-not-set--mail-host-address--so-tickle-me>
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41226)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpYvW-0002TL-M1
	for guix-devel@gnu.org; Fri, 23 Oct 2015 05:46:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpYvR-0000zC-MJ
	for guix-devel@gnu.org; Fri, 23 Oct 2015 05:46:22 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:19176 helo=mx-out02.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpYvR-0000yt-G3
	for guix-devel@gnu.org; Fri, 23 Oct 2015 05:46:17 -0400
In-reply-to: <87si517rav.fsf@SIRIUSGUIX00.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyrill Schenkel <cyrill.schenkel@gmail.com>
Cc: guix-devel@gnu.org

Hello Cyrill,

Small comment.

> From dc8d0477c0644e9d54ebba6af955c3d4e29270fc Mon Sep 17 00:00:00 2001
> From: Cyrill Schenkel <cyrill.schenkel@gmail.com>
> Date: Fri, 23 Oct 2015 13:25:11 +0200
> Subject: [PATCH] gnu: Add xcompmgr
> 
> * gnu/packages/xorg.scm (xcompmgr): New variable.
> ---
>  gnu/packages/xorg.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index b39bbd4..d51cd30 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -4,6 +4,7 @@
> [...]
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before 'configure 'autogen
> +                              (lambda _
> +                                (setenv "NOCONFIGURE" "t")
> +                                (zero? (system* "./autogen.sh")))))))
> +    (native-inputs
> [...]

Mark Weaver recently told me that autogen phases should be after 'unpack
instead of before 'configure, since the MIPS platform (and perhaps
others) sometimes need to adjust the output of autogen.sh.

I'll leave the real review to others :).

Kind regards,
p.