Re: [PATCH] gnu: Add xcompmgr

[Paul van der Walt <paul@denknerd.org>]

Hello Cyrill,

Small comment.

> From dc8d0477c0644e9d54ebba6af955c3d4e29270fc Mon Sep 17 00:00:00 2001
> From: Cyrill Schenkel <cyrill.schenkel@gmail.com>
> Date: Fri, 23 Oct 2015 13:25:11 +0200
> Subject: [PATCH] gnu: Add xcompmgr
> 
> * gnu/packages/xorg.scm (xcompmgr): New variable.
> ---
>  gnu/packages/xorg.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index b39bbd4..d51cd30 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -4,6 +4,7 @@
> [...]
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before 'configure 'autogen
> +                              (lambda _
> +                                (setenv "NOCONFIGURE" "t")
> +                                (zero? (system* "./autogen.sh")))))))
> +    (native-inputs
> [...]

Mark Weaver recently told me that autogen phases should be after 'unpack
instead of before 'configure, since the MIPS platform (and perhaps
others) sometimes need to adjust the output of autogen.sh.

I'll leave the real review to others :).

Kind regards,
p.