From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] gnu: ladspa: Update urls.
Date: Thu, 12 Nov 2015 21:11:34 +0300
Message-ID: <87si4bqe95.fsf@gmail.com>
References: <CADrxHD-cPNai_RFk9PB=zsg_L7RDOjoqH=rt7zfL27bLdb-zOQ@mail.gmail.com>
	<20151112162706.3b57c1e5@debian-netbook>
	<CADrxHD966OU_cFRVPDpos3Pdtg_wZfv14nDS0k4AktL_BTvj8w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41830)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZwwLV-0000E6-49
	for guix-devel@gnu.org; Thu, 12 Nov 2015 13:11:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZwwLR-0006X0-W1
	for guix-devel@gnu.org; Thu, 12 Nov 2015 13:11:41 -0500
Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:36730)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZwwLR-0006WT-OQ
	for guix-devel@gnu.org; Thu, 12 Nov 2015 13:11:37 -0500
Received: by lfs39 with SMTP id 39so38977059lfs.3
	for <guix-devel@gnu.org>; Thu, 12 Nov 2015 10:11:36 -0800 (PST)
In-Reply-To: <CADrxHD966OU_cFRVPDpos3Pdtg_wZfv14nDS0k4AktL_BTvj8w@mail.gmail.com>
	(Alex Vong's message of "Thu, 12 Nov 2015 22:34:22 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Vong <alexvong1995@gmail.com>
Cc: guix-devel@gnu.org

Alex Vong (2015-11-12 17:34 +0300) wrote:

[...]
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index a6899a0..9ed21bd 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -758,7 +758,9 @@ plugin function as a JACK application.")
>      (source (origin
>               (method url-fetch)
>               (uri (string-append
> -                   "http://www.ladspa.org/download/ladspa_sdk_"
> +                   "http://slackware.org.uk/slacky/slackware-13.0/multimedia/ladspa/"
> +                   version
> +                   "/src/ladspa_sdk_"
>                     version
>                     ".tgz"))

Please keep lines within 78 columns.  Split that long string, for
example like this:

             (uri (string-append
                   "http://slackware.org.uk/slacky/slackware-13.0"
                   "/multimedia/ladspa/" version
                   "/src/ladspa_sdk_" version ".tgz"))


>               (sha256
> @@ -781,7 +783,8 @@ plugin function as a JACK application.")
>                (("^CC.*")            "CC = gcc\n")
>                (("^CPP.*")           "CPP = g++\n"))))
>          (alist-delete 'build %standard-phases))))
> -    (home-page "http://ladspa.org")
> +    (home-page "https://community.ardour.org/files/doxygen/ladspa_8h_source.html")  ; Since the home page is gone,
> +    ;; we provide a link to the self-documented header file.

This ^^^ is an unusual way to write a comment.  I think it's better to
do it like this:

    ;; Since the home page is gone, we provide a link to the
    ;; self-documented header file.
    (home-page
     "https://community.ardour.org/files/doxygen/ladspa_8h_source.html")

Also as the home-page line is too long, I split it into 2 lines.

-- 
Alex