Lint on line

Lint on line

[Ludovic Courtès]

Hello, Guix!

Here’s a new tool!

  https://www.gnu.org/software/guix/packages/issues.html

Well, not so new, because it’s basically ‘guix lint’.  But here it also
runs the ‘source’ and ‘home-page’ checkers for every package, which you
would rarely do on your machine because it takes 2–3 hours for the whole
set of packages (mostly waiting for name lookups and TCP connections to
complete.)  It’s like a little MORECOWBELL¹.

Currently it’s scheduled to run every day, but maybe we’ll have to
change that to every few days.

The output is ugly, but you can help!  This is happening in (www
packages), in <http://git.savannah.gnu.org/cgit/guix/guix-artwork.git>.

And of course, you’re welcome to help fix the issues.  :-)

Ludo’.

¹ https://gnunet.org/mcb

Re: Lint on line

[Leo Famulari]

What is the recommended way to handle the following warning?

"gnu/packages/firmware.scm:33:12: ath9k-htc-firmware-1.4.0: the source
file name should contain the package name"

On Sun, Nov 22, 2015, at 18:11, Ludovic Courtès wrote:
> Hello, Guix!
> 
> Here’s a new tool!
> 
>   https://www.gnu.org/software/guix/packages/issues.html
> 
> Well, not so new, because it’s basically ‘guix lint’.  But here it also
> runs the ‘source’ and ‘home-page’ checkers for every package, which you
> would rarely do on your machine because it takes 2–3 hours for the whole
> set of packages (mostly waiting for name lookups and TCP connections to
> complete.)  It’s like a little MORECOWBELL¹.
> 
> Currently it’s scheduled to run every day, but maybe we’ll have to
> change that to every few days.
> 
> The output is ugly, but you can help!  This is happening in (www
> packages), in <http://git.savannah.gnu.org/cgit/guix/guix-artwork.git>.
> 
> And of course, you’re welcome to help fix the issues.  :-)
> 
> Ludo’.
> 
> ¹ https://gnunet.org/mcb
> 

Re: Lint on line

[Alex Kost]

Leo Famulari (2015-11-23 03:22 +0300) wrote:

> What is the recommended way to handle the following warning?
>
> "gnu/packages/firmware.scm:33:12: ath9k-htc-firmware-1.4.0: the source
> file name should contain the package name"

It means that the source file name should be
"/gnu/store/…-ath9k-htc-firmware-1.4.0", while it is probably
"/gnu/store/…-git-checkout" or something.

To fix it, 'file-name' field should be added to the source origin.  Look
for example at 'minetest' or 'mars' package recipes.

-- 
Alex

Re: Lint on line

[Mathieu Lirzin]

ludo@gnu.org (Ludovic Courtès) writes:

> Hello, Guix!
>
> Here’s a new tool!
>
>   https://www.gnu.org/software/guix/packages/issues.html

This is really useful for the scaling of the package maintenance.
Thanks!

--
Mathieu Lirzin

Re: Lint on line

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Leo Famulari <leo@famulari.name> skribis:

> What is the recommended way to handle the following warning?
>
> "gnu/packages/firmware.scm:33:12: ath9k-htc-firmware-1.4.0: the source
> file name should contain the package name"

Like this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 509 bytes --]

diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
index 97f2975..271fb49 100644
--- a/gnu/packages/firmware.scm
+++ b/gnu/packages/firmware.scm
@@ -38,6 +38,7 @@
               (sha256
                (base32
                 "16jbj8avg5jkgvq5lxm0hdxxn4c3zn7fx8b4nxllvr024apk9w23"))
+              (file-name (string-append name "-" version "-checkout"))
               (patches (list (search-patch "ath9k-htc-firmware-objcopy.patch")))))
     (build-system gnu-build-system)
     (arguments

[-- Attachment #3: Type: text/plain, Size: 218 bytes --]


I’ll push this one.  ;-)

The goal of this rule is to make sure that checkouts are given
meaningful names.  This does not make any functional difference, but it
helps keep the store tidy.

Thanks,
Ludo’.

Re: Lint on line

[Andreas Enge]

On Mon, Nov 23, 2015 at 12:11:13AM +0100, Ludovic Courtès wrote:
> Here’s a new tool!
>   https://www.gnu.org/software/guix/packages/issues.html

Very interesting! How about omitting all the packages with "Nothing to
declare!" from the web page?

Andreas

Re: Lint on line

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> On Mon, Nov 23, 2015 at 12:11:13AM +0100, Ludovic Courtès wrote:
>> Here’s a new tool!
>>   https://www.gnu.org/software/guix/packages/issues.html
>
> Very interesting! How about omitting all the packages with "Nothing to
> declare!" from the web page?

Initially I left them so that each package at gnu.org/s/guix/packages
could contain a reference to its (possibly empty) issue list (each
package has an anchor in issues.html.)

Do you think that would make sense?

Ludo’.

Re: Lint on line

[Jan Synáček]

On Tue, Dec 1, 2015 at 11:04 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> Andreas Enge <andreas@enge.fr> skribis:
>
>> On Mon, Nov 23, 2015 at 12:11:13AM +0100, Ludovic Courtès wrote:
>>> Here’s a new tool!
>>>   https://www.gnu.org/software/guix/packages/issues.html
>>
>> Very interesting! How about omitting all the packages with "Nothing to
>> declare!" from the web page?
>
> Initially I left them so that each package at gnu.org/s/guix/packages
> could contain a reference to its (possibly empty) issue list (each
> package has an anchor in issues.html.)
>
> Do you think that would make sense?

Or maybe one extra button and a tiny piece of javascript to show/hide
the no-issue packages?

-- 
Jan Synáček

Re: Lint on line

[Andreas Enge]

On Wed, Dec 02, 2015 at 08:36:30AM +0100, Jan Synáček wrote:
> On Tue, Dec 1, 2015 at 11:04 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> > Initially I left them so that each package at gnu.org/s/guix/packages
> > could contain a reference to its (possibly empty) issue list (each
> > package has an anchor in issues.html.)
> > Do you think that would make sense?

One could drop the link if there are no issues. But that would assume
that the package list page is aware of the issue page and is recreated
each time the issue page changes.

> Or maybe one extra button and a tiny piece of javascript to show/hide
> the no-issue packages?

That sounds like a nice solution. Empty issue list could be of a special
css class, which would make implementing this easy.

Andreas

Re: Lint on line

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> On Wed, Dec 02, 2015 at 08:36:30AM +0100, Jan Synáček wrote:
>> On Tue, Dec 1, 2015 at 11:04 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>> > Initially I left them so that each package at gnu.org/s/guix/packages
>> > could contain a reference to its (possibly empty) issue list (each
>> > package has an anchor in issues.html.)
>> > Do you think that would make sense?
>
> One could drop the link if there are no issues. But that would assume
> that the package list page is aware of the issue page and is recreated
> each time the issue page changes.

Right, and that’s not the case.  The pages are built separately; the
package pages is built in seconds, whereas the issue pages is built in
hours.

>> Or maybe one extra button and a tiny piece of javascript to show/hide
>> the no-issue packages?
>
> That sounds like a nice solution. Empty issue list could be of a special
> css class, which would make implementing this easy.

That would be nice.  Any takers?
See <http://git.savannah.gnu.org/cgit/guix/guix-artwork.git>.

Thanks,
Ludo’.