From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH, WIP, v2] new variable: redshift
Date: Mon, 14 Dec 2015 00:41:17 +0100
Message-ID: <87si35udb6.fsf@gnu.org>
References: <20151124092805.512230c8@gmx.net> <56693203.9060500@gmx.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a8GGZ-0006LR-Rg
	for guix-devel@gnu.org; Sun, 13 Dec 2015 18:41:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a8GGW-0005JM-LT
	for guix-devel@gnu.org; Sun, 13 Dec 2015 18:41:23 -0500
In-Reply-To: <56693203.9060500@gmx.net> (Florian Paul Schmidt's message of
	"Thu, 10 Dec 2015 09:04:19 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Florian Paul Schmidt <mista.tapas@gmx.net>
Cc: guix-devel@gnu.org

Florian Paul Schmidt <mista.tapas@gmx.net> skribis:

> I wanted to try the --rounds=3D3 option, but since it was already built I
> was at a loss about how to make it run a few rounds..

=E2=80=98--check=E2=80=99 can be used in that case.  I did --rounds=3D3 tho=
ugh and it
passes.  :-)

> From f35546e7679e39f5f9cd790c1a9cb27e7b7825b1 Mon Sep 17 00:00:00 2001
> From: Florian Paul Schmidt <mista.tapas@gmx.net>
> Date: Thu, 10 Dec 2015 08:57:57 +0100
> Subject: [PATCH] gnu: Add redshift
>
> * gnu/packages/xdisorg.scm (redshift): New variable.

[...]

> +       ("geoclue" ,geoclue)))

This doesn=E2=80=99t work; instead one has to pass GLib to get Geoclue2 sup=
port,
which is what I did.

However, I found out that Geoclue2 seems to be broken on GuixSD:

--8<---------------cut here---------------start------------->8---
Dec 14 00:28:39 localhost dbus[435]: [system] Activating service name=3D'or=
g.freedesktop.GeoClue2' (using servicehelper)
Dec 14 00:28:39 localhost dbus[435]: [system] Successfully activated servic=
e 'org.freedesktop.GeoClue2'
Dec 14 00:28:39 localhost dbus[435]: [system] Rejected send message, 1 matc=
hed rules; type=3D"method_call", sender=3D":1.74" (uid=3D993 pid=3D24166 co=
mm=3D"/gnu/store/sidpj3m8aarbvhflzvhgmp43gkmcx55z-geoclu") interface=3D"org=
.freedesktop.DBus.Properties" member=3D"GetAll" error name=3D"(unset)" requ=
ested_reply=3D"0" destination=3D"org.freedesktop.DBus" (bus)
--8<---------------cut here---------------end--------------->8---

Ideas?

In the meantime, one can work around it by using:

  redshift -l LATITUDE:LONGITUDE

> +    (synopsis
> +     "Adjusts your screen's color temperature
> +according to your surroundings")

I=E2=80=99ve made this one line and slightly shorter=E2=80=A6

> +    (description
> +     "Redshift adjusts the color temperature according to the
> +position of the sun.  A different color temperature is set during night =
and
> +daytime.  During twilight and early morning, the color temperature trans=
itions
> +smoothly from night to daytime temperature to allow your eyes to slowly
> +adapt.  At night the color temperature should be set to match the lamps =
in your
> +room.")

=E2=80=A6 and reflowed this paragraph.

I also added a copyright line for you, and pushed.

Thanks!

Ludo=E2=80=99.