From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [v3 2/2] gnu: w3m: Enable SSL,
	disable broken protocols and ciphers.
Date: Wed, 06 Jan 2016 11:52:07 +0100
Message-ID: <87si2bgeug.fsf@gnu.org>
References: <9d18197ecca4fe8509e9fa7588f93b9f41ad56e1.1452045889.git.leo@famulari.name>
	<9d18197ecca4fe8509e9fa7588f93b9f41ad56e1.1452045889.git.leo@famulari.name>
	<5ea735685b49a166c74b756cb311e8a6142e132c.1452045889.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40177)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aGlhO-0002a1-LW
	for guix-devel@gnu.org; Wed, 06 Jan 2016 05:52:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aGlhK-0001DK-Ch
	for guix-devel@gnu.org; Wed, 06 Jan 2016 05:52:14 -0500
In-Reply-To: <5ea735685b49a166c74b756cb311e8a6142e132c.1452045889.git.leo@famulari.name>
	(Leo Famulari's message of "Tue, 5 Jan 2016 21:05:00 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/patches/w3m-force-ssl_verify_server-on.patch: New file.
> * gnu/packages/patches/w3m-disable-sslv2-and-sslv3.patch: New file.
> * gnu/packages/patches/w3m-disable-weak-ciphers.patch: New file.
> * gnu/packages/w3m.scm (w3m)[source]: Add patches.
> * gnu-system.am (dist_patch_DATA): Add the new files.

Please add:

  Fixes <http://bugs.gnu.org/16791>.

> +From 7b8d2dbc41b6bdab09e2e632e8481f6e8b585a42 Mon Sep 17 00:00:00 2001
> +From: Leo Famulari <leo@famulari.name>
> +Date: Tue, 5 Jan 2016 17:15:33 -0500
> +Subject: [PATCH 3/4] Disable SSLv2 and SSLv3.

I would remove the Git header from the patches (since they are from a
local repository I guess?) and keep only the subject line and
description.

Otherwise LGTM!

Thanks for working on one of the oldest bug reports.  :-)

Ludo=E2=80=99.