unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [v3 2/2] gnu: w3m: Enable SSL, disable broken protocols and ciphers.
Date: Wed, 06 Jan 2016 11:52:07 +0100	[thread overview]
Message-ID: <87si2bgeug.fsf@gnu.org> (raw)
In-Reply-To: <5ea735685b49a166c74b756cb311e8a6142e132c.1452045889.git.leo@famulari.name> (Leo Famulari's message of "Tue, 5 Jan 2016 21:05:00 -0500")

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/patches/w3m-force-ssl_verify_server-on.patch: New file.
> * gnu/packages/patches/w3m-disable-sslv2-and-sslv3.patch: New file.
> * gnu/packages/patches/w3m-disable-weak-ciphers.patch: New file.
> * gnu/packages/w3m.scm (w3m)[source]: Add patches.
> * gnu-system.am (dist_patch_DATA): Add the new files.

Please add:

  Fixes <http://bugs.gnu.org/16791>.

> +From 7b8d2dbc41b6bdab09e2e632e8481f6e8b585a42 Mon Sep 17 00:00:00 2001
> +From: Leo Famulari <leo@famulari.name>
> +Date: Tue, 5 Jan 2016 17:15:33 -0500
> +Subject: [PATCH 3/4] Disable SSLv2 and SSLv3.

I would remove the Git header from the patches (since they are from a
local repository I guess?) and keep only the subject line and
description.

Otherwise LGTM!

Thanks for working on one of the oldest bug reports.  :-)

Ludo’.

  reply	other threads:[~2016-01-06 10:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06  2:04 [v3 1/2] gnu: w3m: Update patch to use '-p1' Leo Famulari
2016-01-06  2:05 ` [v3 2/2] gnu: w3m: Enable SSL, disable broken protocols and ciphers Leo Famulari
2016-01-06 10:52   ` Ludovic Courtès [this message]
2016-01-07  7:37     ` Leo Famulari
2016-01-06 10:33 ` [v3 1/2] gnu: w3m: Update patch to use '-p1' Ludovic Courtès
2016-01-07  7:30   ` Leo Famulari
2016-01-10 20:36     ` Ludovic Courtès
2016-01-06 10:33 ` Ludovic Courtès
2016-01-07  7:30   ` Leo Famulari
2016-01-10 20:34     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si2bgeug.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).