From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [PATCH 4/4] gnu: Add gst-python.
Date: Mon, 07 Mar 2016 09:59:08 +0800
Message-ID: <87si03t5eb.fsf@member.fsf.org>
References: <1457248078-13098-1-git-send-email-iyzsong@gmail.com>
	<1457248078-13098-4-git-send-email-iyzsong@gmail.com>
	<877fhfchy3.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1ackSa-0003Ar-Jx
	for guix-devel@gnu.org; Sun, 06 Mar 2016 20:59:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1ackSX-0002zL-Ej
	for guix-devel@gnu.org; Sun, 06 Mar 2016 20:59:48 -0500
Received: from smtp21.openmailbox.org ([62.4.1.55]:42091)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1ackSX-0002zE-8Y
	for guix-devel@gnu.org; Sun, 06 Mar 2016 20:59:45 -0500
In-Reply-To: <877fhfchy3.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
	=?utf-8?Q?s?= message of "Mon, 07 Mar 2016 00:20:04 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/gstreamer.scm (python-gst, python2-gst): New variables.
>
> [...]
>
>> +    (arguments
>> +     `(#:configure-flags
>> +       (let ((python-sitedir
>> +              ;; XXX: make this a package property?
>> +              ,(string-append "lib/python"
>> +                              (version-major+minor (package-version pyt=
hon))
>> +                              "/site-packages")))
>
> I think the directory name should be computed on the =E2=80=9Cbuild side=
=E2=80=9D,
> possibly using =E2=80=98get-python-version=E2=80=99 from (guix build
> python-build-system) or something equivalent.
>
> That way, =E2=80=98python2-gst=E2=80=99 wouldn=E2=80=99t have to duplicat=
e this snippet.
Cool, I did that and pushed, with comment that =E2=80=98get-python-version=
=E2=80=99 is a
private function, hope someone will factorize it later.


Thanks for the reviews!