unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: iyzsong@member.fsf.org (宋文武)
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/4] gnu: Add gst-python.
Date: Mon, 07 Mar 2016 09:59:08 +0800	[thread overview]
Message-ID: <87si03t5eb.fsf@member.fsf.org> (raw)
In-Reply-To: <877fhfchy3.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 07 Mar 2016 00:20:04 +0100")

ludo@gnu.org (Ludovic Courtès) writes:

> 宋文武 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/gstreamer.scm (python-gst, python2-gst): New variables.
>
> [...]
>
>> +    (arguments
>> +     `(#:configure-flags
>> +       (let ((python-sitedir
>> +              ;; XXX: make this a package property?
>> +              ,(string-append "lib/python"
>> +                              (version-major+minor (package-version python))
>> +                              "/site-packages")))
>
> I think the directory name should be computed on the “build side”,
> possibly using ‘get-python-version’ from (guix build
> python-build-system) or something equivalent.
>
> That way, ‘python2-gst’ wouldn’t have to duplicate this snippet.
Cool, I did that and pushed, with comment that ‘get-python-version’ is a
private function, hope someone will factorize it later.


Thanks for the reviews!

  reply	other threads:[~2016-03-07  1:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-06  7:07 [PATCH 1/4] gnu: orc: Update to 0.4.25 宋文武
2016-03-06  7:07 ` [PATCH 2/4] gnu: python-pygobject: Add search path for GI_TYPELIB_PATH 宋文武
2016-03-06 23:15   ` Ludovic Courtès
2016-03-06  7:07 ` [PATCH 3/4] gnu: python-pygobject: Propagate glib and libffi 宋文武
2016-03-06 23:17   ` Ludovic Courtès
2016-03-06  7:07 ` [PATCH 4/4] gnu: Add gst-python 宋文武
2016-03-06  7:15   ` Efraim Flashner
2016-03-06  7:25     ` 宋文武
2016-03-06 23:20   ` Ludovic Courtès
2016-03-07  1:59     ` 宋文武 [this message]
2016-03-06 23:14 ` [PATCH 1/4] gnu: orc: Update to 0.4.25 Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si03t5eb.fsf@member.fsf.org \
    --to=iyzsong@member.fsf.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).