From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] Add MilkyTracker to Guix Date: Mon, 28 Mar 2016 13:46:06 +0300 Message-ID: <87shzayj69.fsf@gmail.com> References: <6dae35698781717e6043be7086b6f63c@openmailbox.org> <20160327072337.GA13339@debian-netbook> <20160327230935.14e8ba5a@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akUgV-0002nd-BI for guix-devel@gnu.org; Mon, 28 Mar 2016 06:46:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akUgS-0002x3-6T for guix-devel@gnu.org; Mon, 28 Mar 2016 06:46:11 -0400 Received: from mail-lb0-x229.google.com ([2a00:1450:4010:c04::229]:35638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akUgR-0002wu-V1 for guix-devel@gnu.org; Mon, 28 Mar 2016 06:46:08 -0400 Received: by mail-lb0-x229.google.com with SMTP id bc4so79252861lbc.2 for ; Mon, 28 Mar 2016 03:46:07 -0700 (PDT) In-Reply-To: <20160327230935.14e8ba5a@openmailbox.org> (Kei Yamashita's message of "Sun, 27 Mar 2016 23:09:35 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Kei Yamashita Cc: guix-devel@gnu.org Kei Yamashita (2016-03-28 06:09 +0300) wrote: > On Sun, 27 Mar 2016 10:23:37 +0300 > Efraim Flashner wrote: >> On Fri, Mar 25, 2016 at 07:54:40PM -0400, kei@openmailbox.org wrote: [...] >> > + (arguments >> > + '(#:configure-flags `("--without-alsa" "--without-jack"))) >> >> In addition to Nil's comments, I was wondering about the configure >> flags. Wouldn't it make sense to have either alsa or jack as an input? > > Milkytracker works fine without it on my machine. I feel like it's a > matter of allowing the user options or sticking to the minimal build. In my understanding (I may be wrong) our policy is to provide full-featured software, so the features shouldn't be disabled without a reason. Sometimes we add minimal packages (e.g., "bash-minimal", "cups-minimal") if they are needed, but this is not such a case. So I think you should remove these --without-=E2=80=A6 flags. And thanks f= or contributing! --=20 Alex