From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] build: Move included files to subdirectories.
Date: Thu, 14 Apr 2016 19:46:31 +0200 [thread overview]
Message-ID: <87shyohymg.fsf@gnu.org> (raw)
In-Reply-To: <20160403213616.52b60218@openmailbox.org> (Eric Bavier's message of "Sun, 3 Apr 2016 21:36:16 -0500")
Eric Bavier <ericbavier@openmailbox.org> skribis:
> On Sun, 3 Apr 2016 18:18:45 +0200
> Mathieu Lirzin <mthl@gnu.org> wrote:
>
>> This follows a convention used by some other GNU packages like Autoconf,
>> Bison, Coreutils, and Gnulib.
>>
>> * doc.am: Rename to ...
>> * doc/local.mk: ... this.
>> * emacs.am: Rename to ...
>> * emacs/local.mk: ... this.
>> * gnu-system.am: Rename to ...
>> * gnu/local.mk: ... this.
>> * daemon.am: Rename to ...
>> * nix/local.mk: ... this.
>> * Makefile.am: Adapt to them.
>> * doc/guix.texi (Porting to a New Platform): Adapt documentation.
>> * guix/config.scm.in (%state-directory, %config-directory): Adapt comments.
>> * emacs/guix-config.el.in (guix-config-state-directory): Likewise.
>> ---
>> Makefile.am | 8 +-
>> daemon.am | 226 -------------
>> doc.am | 157 ---------
>> doc/guix.texi | 2 +-
>> doc/local.mk | 157 +++++++++
>> emacs.am | 73 ----
>> emacs/guix-config.el.in | 2 +-
>> emacs/local.mk | 73 ++++
>> gnu-system.am | 883 ------------------------------------------------
>> gnu/local.mk | 883 ++++++++++++++++++++++++++++++++++++++++++++++++
>> guix/config.scm.in | 4 +-
>> nix/local.mk | 226 +++++++++++++
>> 12 files changed, 1347 insertions(+), 1347 deletions(-)
>> delete mode 100644 daemon.am
>> delete mode 100644 doc.am
>> create mode 100644 doc/local.mk
>> delete mode 100644 emacs.am
>> create mode 100644 emacs/local.mk
>> delete mode 100644 gnu-system.am
>> create mode 100644 gnu/local.mk
>> create mode 100644 nix/local.mk
>>
>
> I don't prefer the "local.mk" convention. It becomes
> non-obvious that the file is input for Automake, and the name loses any
> descriptive power.
I have mixed feelings (notably because file names in those .mk files
remain relative to $top_srcdir, which can be confusing and will make M-/
useless), but I sympathize with the initial motivation, and I think it
can’t hurt to follow the same conventions as important GNU packages.
So if there aren’t any strong objections within a day or two, I’d say go
for it!
Thanks,
Ludo’.
next prev parent reply other threads:[~2016-04-14 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 16:18 [PATCH 0/2] Clean repository top-level directory Mathieu Lirzin
2016-04-03 16:18 ` [PATCH 1/2] build: Move included files to subdirectories Mathieu Lirzin
2016-04-04 2:36 ` Eric Bavier
2016-04-14 17:46 ` Ludovic Courtès [this message]
2016-04-14 22:55 ` Mathieu Lirzin
2016-04-16 22:54 ` Ludovic Courtès
2016-05-21 21:41 ` Mathieu Lirzin
2016-05-22 20:33 ` Ludovic Courtès
2016-04-03 16:18 ` [PATCH 2/2] build: Move environment scripts to 'build-aux' directory Mathieu Lirzin
2016-04-03 17:05 ` Alex Kost
2016-04-03 17:18 ` Mathieu Lirzin
2016-04-03 21:56 ` Alex Kost
2016-04-03 18:19 ` Leo Famulari
2016-04-03 19:19 ` Mathieu Lirzin
2016-04-14 17:48 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shyohymg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).