From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Add cabextract.
Date: Sun, 17 Apr 2016 11:32:24 +0200
Message-ID: <87shykzil3.fsf@elephly.net>
References: <20160416200555.40122bfd@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60779)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1arj4H-0002K7-Q0
	for guix-devel@gnu.org; Sun, 17 Apr 2016 05:32:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1arj4E-0006UL-Gf
	for guix-devel@gnu.org; Sun, 17 Apr 2016 05:32:37 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24317)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1arj4E-0006Tr-90
	for guix-devel@gnu.org; Sun, 17 Apr 2016 05:32:34 -0400
In-reply-to: <20160416200555.40122bfd@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org


Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi,
>
> this patch adds cabextract, an extractor for CAB files. (libmspack is already in, but cabextract isn't)
>
>   * gnu/packages/compression.scm (cabextract): New variable.
> ---
>  b/gnu/packages/compression.scm |   23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
> index 938d4b8..9343e85 100644
> --- a/gnu/packages/compression.scm
> +++ b/gnu/packages/compression.scm
> @@ -688,3 +688,26 @@ a collection of smaller blocks which makes random access to the original data
>  possible and can compress in parallel.  This is especially useful for large
>  tarballs.")
>      (license license:bsd-2)))
> +
> +(define-public cabextract
> + (package
> +   (name "cabextract")
> +   (version "1.6")
> +   (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://cabextract.org.uk/cabextract-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1ysmmz25fjghq7mxb2anyyvr1ljxqxzi4piwjhk0sdamcnsn3rnf"))))
> +    (build-system gnu-build-system)
> +    (arguments '(#:configure-flags '("--with-external-libmspack")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ))

Please move these two closing parentheses to the previous line.

> +    (inputs
> +     `(("libmspack" ,libmspack)))
> +    (home-page "http://www.cabextract.org.uk/")
> +    (synopsis "CAB Extractor")
> +    (description "cabextract extracts files from CAB archives.")

Both synopsis and description are very terse.  For the synopsis
something like “Tool to unpack CAB archives” might be a little less
cryptic.  I don’t have any alternative for the description, but it would
be nice if it were a little less terse.

> +    (license (list license:gpl2 license:gpl3))))

Could you add a comment explaining what this means?  Are parts of the
code released under GPLv2 only?

~~ Ricardo