From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [Patch] go@1.4 Updated patch
Date: Tue, 14 Jun 2016 14:45:46 +0200
Message-ID: <87shwgdjlx.fsf@gnu.org>
References: <87fusuh52h.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	<1464968435.2613720.627094929.3FEBB927@webmail.messagingengine.com>
	<87d1nygoiq.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	<871t4a7mkr.fsf@igalia.com>
	<8737omgukj.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	<877fdukya9.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bCnjA-000492-Vn
	for guix-devel@gnu.org; Tue, 14 Jun 2016 08:45:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bCnj5-0001xI-16
	for guix-devel@gnu.org; Tue, 14 Jun 2016 08:45:55 -0400
In-Reply-To: <877fdukya9.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Sun, 12 Jun 2016 21:22:22 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Matthew Jordan <matthewjordandevops@yandex.com>
Cc: guix-devel@gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> It seems we=E2=80=99re almost done!  I was about to commit it with the ch=
anges
> below on top of the patch you posted (they are mostly cosmetic.)
>
> Since there are parts I don=E2=80=99t fully understand, I thought I=E2=80=
=99d leave it
> up to you.  In particular, could you could at least replace the =E2=80=9C=
why=E2=80=9D in
> the comments below with explanations of why this is done?
>
> Also, why do we need this =E2=80=9Csrc=E2=80=9D output?  IIUC, it contain=
s the source of
> some of the unit tests, right?

One last thing I forgot to mention: building with --rounds=3D2 shows that
the build is not reproducible (some differences in a few .a files.)

If you prefer, we can address it in a later patch, though.

Thanks,
Ludo=E2=80=99.