From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: Add perltidy. Date: Tue, 5 Jul 2016 15:57:30 +0200 Message-ID: <87shvokx11.fsf@mdc-berlin.de> References: <87oa6c5uty.fsf@gnu.org> <87lh1g5oik.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKQr8-0002av-1Z for guix-devel@gnu.org; Tue, 05 Jul 2016 09:57:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKQr3-000590-Qq for guix-devel@gnu.org; Tue, 05 Jul 2016 09:57:41 -0400 In-Reply-To: <87lh1g5oik.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel Roel Janssen writes: > Ricardo Wurmus writes: > >> Roel Janssen writes: >> >>> Here I have a package recipe for perltidy. The version number differ= s >>> from the usual scheme, but that's what the project uses, so I cannot = do >>> much about it. >> >> I don=E2=80=99t think that=E2=80=99s a problem. >> >>>>From d6cc1580a362f759bbd85107435a47c0eac04954 Mon Sep 17 00:00:00 200= 1 >>> From: Roel Janssen >>> Date: Tue, 5 Jul 2016 10:51:58 +0200 >>> Subject: [PATCH] gnu: Add perltidy. >>> >>> * gnu/packages/perl.scm (perltidy): New variable. >>> --- >>> gnu/packages/perl.scm | 22 ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm >>> index 74a47b4..e34515e 100644 >>> --- a/gnu/packages/perl.scm >>> +++ b/gnu/packages/perl.scm >>> @@ -9,6 +9,7 @@ >>> ;;; Copyright =C2=A9 2016 Efraim Flashner >>> ;;; Coypright =C2=A9 2016 ng0 >>> ;;; Copyright =C2=A9 2016 Alex Sassmannshausen >>> +;;; Copyright =C2=A9 2016 Roel Janssen >>> ;;; >>> ;;; This file is part of GNU Guix. >>> ;;; >>> @@ -5986,6 +5987,27 @@ system.") >>> as exceptions to standard program flow.") >>> (license (package-license perl)))) >>> =20 >>> +(define-public perltidy >>> + (package >>> + (name "perltidy") >> >> =E2=80=9Cperltidy=E2=80=9D (as in the domain name) or =E2=80=9Cperl-ti= dy=E2=80=9D (as in the tarball)? >> I don=E2=80=99t remember what our naming guidelines say about this. (= I think >> =E2=80=9Cperltidy=E2=80=9D is correct.) > > I think they are clear on the project's name. For example, the homepag= e > title: =E2=80=9CThe Perltidy Home Page=E2=80=9D Okay, you=E2=80=99re right. =E2=80=9Cperltidy=E2=80=9D it is, then! :) >>> + (version "20160302") >>> + (source (origin >>> + (method url-fetch) >>> + (uri (string-append "mirror://sourceforge/perltidy/Per= l-Tidy-" >>> + version ".tar.gz")) >>> + (file-name (string-append name "-" version ".tar.gz")) >> >> Is this necessary or can we just keep the tarball name as it is? > > I guess not. I thought we had to rename the tarballs to match the > package names (so in this case, without the dash). If it is not > necessary, I will remove it from the final patch.. I just checked the packaging guidelines in the manual and couldn=E2=80=99= t find any statement on when to use =E2=80=9Cfile-name=E2=80=9D. It is only des= cribed in section 5.1.2: =E2=80=98file-name=E2=80=99 (default: =E2=80=98#f=E2=80=99) The file name under which the source code should be saved. When this is =E2=80=98#f=E2=80=99, a sensible default value wil= l be used in most cases. In case the source is fetched from a URL, the file name from the URL will be used. For version control checkouts, it is recommended to provide the file name explicitly because the default is not very descriptive. I think the original name is descriptive enough as it actually contains the name of the package. So I think you can remove the =E2=80=9Cfile-name=E2=80=9D expression and = push this. ~~ Ricardo