From: ng0 <ng0@we.make.ritual.n0.is>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: dwm: Shorten the description.
Date: Sun, 07 Aug 2016 15:02:41 +0000 [thread overview]
Message-ID: <87shugipv2.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <87lh08lllp.fsf@gmail.com>
Hi,
Alex Kost <alezost@gmail.com> writes:
> ng0 (2016-08-07 15:02 +0300) wrote:
>
>> This description was as long as the package itself. We should not do
>> this, this is enough. Whoever wants to read up on dwm and tiling wm in
>> general can read about it in dwm documentation and other twms.
>
> I agree, so if there are no objections, I'm going to commit it.
>
> ng0, IIUC you don't have commit access to the guix git repo, right?
> Ludovic is on vacations, but if you are willing to have it, I think the
> other project admins wouldn't mind to add you to the Guix group
> <https://savannah.gnu.org/projects/guix/>.
>
> --
> Alex
Thanks Alex.
I had an exchange of messages with Ludovic, where some of the people
with commit access were also CC'd and we (only Ludovic and myself) came
to agree that my work is good but some further mentoring is needed until
I can work completely on my own.
With that in mind, I'd like to have a feedback on what's there to
improve.
I can recall only recall some commit messages which were not completely
correct or otherwise not to the liking of the person who pushed them.
I'd prefer to have feedback first, and opinions of other people with
commit access as I value opinion over just giving access.
Grothoff over at GNUnet handles this differently than Ludovic it seems,
they prefer to give access to regular contributors and fix if a commit
breaks something (of course you shouldn't commit breakage in the first
place if you can avoid it), to take off the annoying task for commiting
trivial fixes in the names of other people. I guess that's why you ask
me, I start to commit so much that with still no review order/framework
in place commit access would make this easier. QA will still apply, but
commiting is also some minutes of work for the person who does it.
--
♥Ⓐ ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org
next prev parent reply other threads:[~2016-08-07 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 12:02 [PATCH] gnu: dwm: Shorten the description ng0
2016-08-07 14:06 ` Alex Kost
2016-08-07 15:02 ` ng0 [this message]
2016-08-11 15:15 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shugipv2.fsf@we.make.ritual.n0.is \
--to=ng0@we.make.ritual.n0.is \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).