From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/3] gnu: Add newlib-arm-none-eabi.
Date: Wed, 21 Sep 2016 17:38:36 +0900
Message-ID: <87shstlkab.fsf@gnu.org>
References: <20160918063513.11027-1-rekado@elephly.net>
	<20160918063513.11027-3-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bmir3-0007pp-JO
	for guix-devel@gnu.org; Wed, 21 Sep 2016 10:50:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bmiqw-0005Yk-JS
	for guix-devel@gnu.org; Wed, 21 Sep 2016 10:50:32 -0400
In-Reply-To: <20160918063513.11027-3-rekado@elephly.net> (Ricardo Wurmus's
	message of "Sun, 18 Sep 2016 08:35:12 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/embedded.scm (newlib-arm-none-eabi): New variable.

[...]

> +       #:configure-flags '("--target=3Darm-none-eabi"
> +                           "--enable-newlib-io-long-long"
> +                           "--enable-newlib-register-fini"
> +                           "--disable-newlib-supplied-syscalls"
> +                           "--disable-nls")

Maybe a short comment to explain.  :-)

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-shell-shebangs
> +           (lambda _
> +             (setenv "SHELL" (which "sh"))
> +             (setenv "CONFIG_SHELL" (which "sh"))
> +             (substitute* '("libgloss/arm/configure"
> +                            "libgloss/arm/cpu-init/Makefile.in"
> +                            "libgloss/arm/Makefile.in"
> +                            "libgloss/libnosys/Makefile.in"
> +                            "libgloss/Makefile.in")
> +               (("/bin/sh") (which "sh")))

Are they not taken care of by the =E2=80=98patch-shebangs=E2=80=99 phase?

Otherwise LGTM, thanks!

Ludo=E2=80=99.